Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate 0.6.0 #146

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Release candidate 0.6.0 #146

merged 6 commits into from
Oct 16, 2024

Conversation

RMHogervorst
Copy link
Contributor

@RMHogervorst RMHogervorst commented Oct 14, 2024

Description

Tasks

  • spelling check
  • missing link in checksum_util
  • change all expect_is, to newer version of test_that:
expect_is(aa, "BaseProvider") ==
    expect_s3_class(aa, "BaseProvider")
expect_is(aa, "R6") ==
    expect_s3_class(aa, "R6")
expect_is(aa$random_element, "function") ==
    expect_type(aa$random_element, "closure")
expect_is(aa$random_element(letters), "character") ==
    expect_type(aa$random_element(letters), "character")
  • see if I can improve test coverage of:
R/onload.R: 0.00%
R/ssn-provider.R: 0.00%
R/coordinate-provider.R: 35.71%
R/misc-provider.R: 42.86%
R/elements.R: 60.00%
R/person-provider-ja_JP.R: 62.50%
R/lorem-provider.R: 66.29%
R/internet-provider.R: 67.89%
R/zzz.R: 70.83%
  • check vignettes

  • revdepcheck

Related Issue

Closes #140

@RMHogervorst RMHogervorst added this to the v0.6 milestone Oct 14, 2024
@RMHogervorst
Copy link
Contributor Author

test coverage 89.81%

@RMHogervorst RMHogervorst marked this pull request as ready for review October 16, 2024 20:00
@RMHogervorst RMHogervorst changed the title Draft: Release candidate 0.6.0 Release candidate 0.6.0 Oct 16, 2024
@RMHogervorst RMHogervorst merged commit 8d0427b into master Oct 16, 2024
6 checks passed
@RMHogervorst RMHogervorst deleted the release/0_6_0 branch October 16, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify other maintainers of the changes in next version
1 participant