Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve main tests #399

Merged
merged 8 commits into from
Oct 25, 2024
Merged

refactor: improve main tests #399

merged 8 commits into from
Oct 25, 2024
+445 −446

Conversation

davidebianchi
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Oct 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11514320176

Details

  • 60 of 69 (86.96%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 84.998%
Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 32 41 78.05%
Files with Coverage Reduction New Missed Lines %
main.go 1 68.39%
Totals Coverage Status
Change from base Build 11501012671: 0.06%
Covered Lines: 2340
Relevant Lines: 2753
💛 - Coveralls

fredmaggiowski
fredmaggiowski requested changes Oct 24, 2024
View reviewed changes
service/statusroutes.go Outdated Show resolved Hide resolved
service/sdkbootstate.go Show resolved Hide resolved
fredmaggiowski
fredmaggiowski approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .....................

@fredmaggiowski fredmaggiowski merged commit 699ec10 into main Oct 25, 2024
10 checks passed
@fredmaggiowski fredmaggiowski deleted the refactor/main-tests branch October 25, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidebianchi @coveralls @fredmaggiowski