Change type of InstanceBuilder.properties to Vec<(Ustr, Variant)> #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the type of
InstanceBuilder.properties
fromUstrMap<Variant
toVec<(Ustr, Variant)>
because I noticed that we were spending a significant amount of time just inserting into this HashMap during deserialization, and we get no benefit from this being a HashMap. The number of keys is usually small, and we only do a lookup here:rbx-dom/rbx_binary/src/deserializer/state.rs
Lines 183 to 191 in e909f45
which is a very cold path.
On my machine, this improves rbx_binary's "Deserialize 10,000 Parts" benchmark by ~11%, and will be even more significant on larger workloads.