Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saying CFrame components are XVector, YVector, and ZVector #365

Merged
merged 1 commit into from
Oct 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/binary.md
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,11 @@ The `CFrame` type is more complicated than other types. To save space, there are

If the byte is `00`, a `CFrame` looks like this:

| Field Name | Format | Value |
|:------------|:------------------------|:-----------------------------------------------------------------------------------------------------|
| ID | `u8` | Always `00` in this case. |
| Orientation | Array of 9 `f32` values | The rotation matrix of the `CFrame`. It represents the XVector, YVector, and ZVector, in that order. |
| Position | [`Vector3`](#vector3) | The position of the `CFrame`. |
| Field Name | Format | Value |
|:------------|:------------------------|:-------------------------------------------------------------------------------------------------------------------|
| ID | `u8` | Always `00` in this case. |
| Orientation | Array of 9 `f32` values | The rotation matrix of the `CFrame`. Contains the components `R00 R01 R02 R10 R11 R12 R20 R21 R22`, in that order. |
| Position | [`Vector3`](#vector3) | The position of the `CFrame`. |

In this case, the `Orientation` field is stored as nine untransformed [IEEE-754 standard](https://en.wikipedia.org/wiki/Single-precision_floating-point_format) 32-bit floats.

Expand Down