Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give BinaryStrings their own documentation #338

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

Dekkonot
Copy link
Member

@Dekkonot Dekkonot commented Aug 3, 2023

MaterialColors and Tag aren't documented right now. This documents them and also moves BinaryStrings their doc page. As a byproduct, I've moved attributes to there too.

I'm not 100% on the formatting I've used for the binary strings spec but hopefully it's good enough.

@Dekkonot Dekkonot added type: enhancement New feature or request module: spec labels Aug 3, 2023
Copy link

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
It's clear and simple to understand - I can't ask for much more!

@Dekkonot Dekkonot merged commit 29b968e into rojo-rbx:master Aug 3, 2023
2 checks passed
@Dekkonot Dekkonot deleted the binary-blob branch August 3, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: spec type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants