Don't serialize ScriptGuid
, UniqueId
, and HistoryId
#327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #314 and resolves #324 for now.
I've decided that
LuaSourceContainer.ScriptGuid
,Instance.UniqueId
, andInstance.HistoryId
shouldn't serialize for the time being. All they do is make diff noise and they aren't especially useful for Rojo or Lune users at this time.In the process, I discovered that
rbx_reflector
actually wasn't catchingUniqueId
properties so I've corrected that. I'll add it to my list of things to check in new data type implementations going forward.