Skip to content

Commit

Permalink
Don't use ahash for reflection
Browse files Browse the repository at this point in the history
  • Loading branch information
kennethloeffler committed Oct 30, 2024
1 parent f4bb8ea commit 70e8cd2
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 7 deletions.
1 change: 0 additions & 1 deletion rbx_reflection/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@ edition = "2018"
[dependencies]
rbx_types = { version = "1.10.0", path = "../rbx_types", features = ["serde"] }

ahash = "0.8.11"
serde = { version = "1.0.137", features = ["derive"] }
thiserror = "1.0.31"
6 changes: 4 additions & 2 deletions rbx_reflection/src/database.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
// for most cases.
#![allow(clippy::new_without_default)]

use std::borrow::Cow;
use std::{
borrow::Cow,
collections::{HashMap, HashSet},
};

use ahash::{HashMap, HashMapExt, HashSet, HashSetExt};
use rbx_types::{Variant, VariantType};
use serde::{Deserialize, Serialize};

Expand Down
3 changes: 1 addition & 2 deletions rbx_reflection/src/serde_util.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
use std::{
collections::{BTreeMap, BTreeSet},
collections::{BTreeMap, BTreeSet, HashMap, HashSet},
hash::Hash,
};

use ahash::{HashMap, HashSet};
use serde::{Serialize, Serializer};

pub(crate) fn ordered_map<S, K, V>(value: &HashMap<K, V>, serializer: S) -> Result<S::Ok, S::Error>
Expand Down
1 change: 0 additions & 1 deletion rbx_reflector/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ rbx_reflection = { path = "../rbx_reflection" }
rbx_types = { path = "../rbx_types", features = ["serde"] }
rbx_xml = { path = "../rbx_xml" }

ahash = "0.8.11"
anyhow = "1.0.57"
clap = { version = "4.1.4", features = ["derive"] }
env_logger = "0.10.0"
Expand Down
2 changes: 1 addition & 1 deletion rbx_reflector/src/cli/generate.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
use std::{
borrow::Cow,
collections::{HashMap, HashSet},
fs::{self, File},
io::{BufWriter, Write},
path::PathBuf,
};

use ahash::{HashMap, HashMapExt, HashSet, HashSetExt};
use anyhow::{bail, Context};
use clap::Parser;
use rbx_reflection::{
Expand Down

0 comments on commit 70e8cd2

Please sign in to comment.