Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readfile bug #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix readfile bug #3

wants to merge 1 commit into from

Conversation

yufernando
Copy link

Set error type to any in catch clause.

@yufernando
Fix readfile bug
7e64d48 
Set error type to any in catch clause.
@robrich
Copy link
Owner

robrich commented Sep 10, 2021

I like where this is going. Any reason you chose not to use (err: Error)?

@yufernando
Copy link
Author

Actually err:Error might be more precise and therefore better.

The err: any is just to avoid the newer versions of Typescript from complaining. If your users are just viewing the git repo locally then it is not a big issue.

@robrich robrich mentioned this pull request Oct 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yufernando @robrich