Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramsetecommand implemented with Overtake and Beartype #42

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

lospugs
Copy link
Contributor

@lospugs lospugs commented Dec 28, 2023

No description provided.

@lospugs
Copy link
Contributor Author

lospugs commented Dec 28, 2023

Are these failures because overtake and beartype aren't available?

I based this branch from the previously successful PR where all the ci/test cases pass.

I did need to separately install overtake and beartype with pip but it does work on my machine.

@virtuald
Copy link
Member

virtuald commented Dec 29, 2023

If you're modifying the package to require packages to be installed, you would need to modify the requirements in setup.py to ensure that they get installed.

Edit: oh, you did. Hm.

self._prevSpeeds = DifferentialDriveWheelSpeeds()
self._prevTime = -1.0
self.usePID = True
# All the parameter checks pass, inform scheduler. Type ignoring is set explictitly for the linter because this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... I don't understand this comment? Shouldn't you unpack here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I keep things as they are with other commands, the '*' throws off the dispatch to the point where incorrect constructors get called, as well as mypy coming up with type errors. Basically, for me to get it to work, I had to declare the requirements explicitly as a Tuple, without unpacking since that's what addRequirements wants. Mypy was not happy with this solution, so I just type:ignore.

There is possibly a way to get it to work, but I couldn't figure it out.

commands2/ramsetecommand.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants