Adds MecanumControllerCommand to Commands2. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuald
reviewed
Dec 7, 2023
| ChassisSpeeds(initialXVelocity, initialYVelocity, 0.0) | ||
| ) | ||
| self.timer.restart() | ||
| self.prevTime = 0 |
There was a problem hiding this comment.
It isn't reset in Java but I guess I just sort of did that because that's how I teach the students to write commands when I teach them.
Not really a bug per se in Java, but I think it should probably be reset to 0 in initialize in Java. I removed it here for parity.
auscompgeek
requested changes
Jan 15, 2024
Comment on lines
+92
to
+99
| feedforward | ||
| or frontLeftController | ||
| or rearLeftController | ||
| or frontRightController | ||
| or rearRightController | ||
| or currentWheelSpeedsSupplier is None | ||
| ): | ||
| raise RuntimeError( |
There was a problem hiding this comment.
If any of
- feedforward
- frontLeftController
- rearLeftController
- frontRightController
- rearRightController
are provided (i.e. not None), won't we always get here? This doesn't seem right.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28