Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(over window): skip remaining affected rows when rank is not changed #18950

Open
wants to merge 1 commit into
base: rc/over-window-state-compute-metric
Choose a base branch
from

Conversation

stdrc
Copy link
Contributor

@stdrc stdrc commented Oct 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

For example:

rank() over (
  partition by ...
  order by val
)

Rows:

 row_id | val | rank
--------|-----|------
 100    | 2   | 1
 101    | 6   | 2
 102    | 7   | 3
 103    | 9   | 4

When changing val of row 101, it will potenrially affect row 102 and 103. Previously, no matter what the val is changed to, we will re-compute all outputs from row 101 to the end of the partition (row 103). After this PR, if the output of row 102 is not changed, we will stop the re-computation.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor Author

stdrc commented Oct 16, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite Graphite

@stdrc stdrc changed the title skip remaining affected curr keys when rank has no change perf(over window): skip remaining affected rows when rank is not changed Oct 16, 2024
@stdrc stdrc marked this pull request as ready for review October 16, 2024 13:38
@st1page st1page self-requested a review October 16, 2024 15:07
@stdrc stdrc force-pushed the rc/over-window-state-compute-metric branch from 9fe13b2 to 746309b Compare October 17, 2024 08:53
@stdrc stdrc force-pushed the rc/over-window-perf-optimization-1 branch from 50e2520 to 4fa1dce Compare October 17, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant