Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic if spawn when task drop with madsim #13417

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: panic if spawn when task drop with madsim #13417

merged 1 commit into from
Nov 14, 2023

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Nov 14, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Temporarily disable file cache insert when memory cache eviction, because it may cause tokio spawn when task drop, which madsim cannot support for now.

FYI: madsim-rs/madsim#182
CI failure: https://buildkite.com/risingwavelabs/pull-request/builds/35387#018bcd05-4da3-488f-839c-412e04b84180

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx added the type/bug Something isn't working label Nov 14, 2023
@MrCroxx MrCroxx self-assigned this Nov 14, 2023
@MrCroxx MrCroxx marked this pull request as ready for review November 14, 2023 09:48
@github-actions github-actions bot added the type/fix Bug fix label Nov 14, 2023
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCroxx MrCroxx added this pull request to the merge queue Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cde91a0) 67.86% compared to head (b092861) 67.87%.

Files Patch % Lines
src/storage/src/hummock/sstable_store.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13417      +/-   ##
==========================================
+ Coverage   67.86%   67.87%   +0.01%     
==========================================
  Files        1526     1526              
  Lines      260047   260053       +6     
==========================================
+ Hits       176468   176508      +40     
+ Misses      83579    83545      -34     
Flag Coverage Δ
rust 67.87% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit ec3208b Nov 14, 2023
32 of 33 checks passed
@MrCroxx MrCroxx deleted the xx/fix-madsim branch November 14, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants