Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include Smclint/Ssclint/Smclic/Ssclic/Smaia/Ssaia as valid options to constants.py #136

Closed
wants to merge 0 commits into from

Conversation

dansmathers
Copy link

For issue: #133
updated constants.py to included Smclint/Ssclint/Smclic/Ssclic/Smaia/Ssaia as valid S_extensions

@neelgala
Copy link
Collaborator

@dansmathers Could you please list out with links to the spec versions you are refering to for this PR ?

Since 'Smclic','Ssclic','Smaia','Ssaia' specs introduce/modify CSRs to the spec, this PR should include those CSR updates as well.

A quick way forward would be to include just the 'Smclint','Ssclint' since they don't introduce any CSRs

Things you need to do anyhow:

  1. install bumpversion using pip install bumpversion
  2. run bumpversion --no-tag --config-file setup.cfg minor. (this should change the version everywhere to 3.10.0)
  3. create an Entry in the CHANGELOG.md for 3.10.0 and highlight the changes done

It would be great if you could update the "Deploying" section in CONTRIBUTING.rst with what you feel will help other contributors as well (ignore if its a bother)

@neelgala
Copy link
Collaborator

@dansmathers riscv-config already has support for indexed registers (since debug uses them a lot).
You can look at the tdata schema for reference. An example of how these are used is provided in the example here

The docs obviously need to be updated for this new type of register which I will push as a new PR

@dansmathers
Copy link
Author

I guess I need help. I tried following the CONTRIBUTING.rst and when I tried git push origin add_smclint, I got this message:

Username for 'https://github.com':
Password for 'https://@github.com':
remote: Support for password authentication was removed on August 13, 2021.
remote: Please see https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls for information on currently recommended modes of authentication.
fatal: Authentication failed for 'https://github.com/riscv-software-src/riscv-config.git/'

Any way I can do this from the gui? gui pulls, issues, etc. seem to work fine.

@dansmathers
Copy link
Author

I guess it closed when I tried to update my branch with the latest. reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants