Named captures to return their names in-order #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the Match::named_groups() function would return names in an arbitrary order, because they were stored in a hash table. Switch to returning them in the original specification order from the pattern. This allows implementing the JS engine semantics where the object key order matches that from the pattern. Fixes #96
ridiculousfish
force-pushed
the
pca-fix-96
branch
from
869b324
to
1412d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the Match::named_groups() function would return names in an arbitrary order, because they were stored in a hash table. Switch to returning them in the original specification order from the pattern. This allows implementing the JS engine semantics where the object key order matches that from the pattern.
Fixes #96