Add option to choose different sample rate #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dalbonio sorry for commenting on this so late. Just wanted to quickly say thanks for this and, although I don't have time to work on this project, if you want to package your fork and make it available on npm I would be happy to mention it in the README here. |
|
Sample rate is related to frame samples. I think it's better to add 'sampleRate' into 'FrameProcessorOptions' and control the default 'frameSamples' based on it." See comments here for more details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ricky, I'm sending this PR because i was trying to use the VAD with a sample rate of 8000, but it had no option of choosing the sample rate. The code is simply treating the sample rate as a variable instead of a fixed value of 16000.
I tried to introduce the changes while maintaining the same parameters and a default value of 16000, so it does not break existing code.