-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direction noise fluctuation post-process #51
base: development
Are you sure you want to change the base?
Conversation
Not at all! I'm glad you not only find it useful but contribute. I hope you don't mind my delays in getting them reviewed and merged. This end of year is providing to be a bit overloading, so I've had to table anything non-fundamental for now. I hope to get around to them before the end of the year, but in fact, let me just add you as a contributor. Cheers! |
There you go. Couple of requests:
Cheers! |
Thanks!
I only see a
Cool, I didn't know what your procedure was here, assumed
👍 given most of these are small refinements is it OK to tweak an existing sample to include it where appropriate?
Not at all, I'm not waiting on anything, I'm just submitting these as I go so I don't forget. I'm happy if I can add something back (and equally relaxed if you say something doesn't fit being upstream) but there's absolutely no rush since I'm using my modified copy. I'm very grateful for your work on this project and don't wish to give you more work to do! :) I won't be at all offended if these PRs sit in the queue until you have some free time, be that day, weeks, months, more or even never 😉 Thanks again! |
You are right. I forgot that I named the one on UnitySteer before I switched naming to the more succinct
Thanks! I usually just add to the changelog under a SNAPSHOT or WIP version. Such conflicts are easy enough to fix if we keep them to one line, one change.
Definitely! Cheers! |
This is just like the speed fluctuation component but gives a little extra variance to final result which helps it look more natural.
BTW: hope you don't mind all these PRs, it's just my principle to contribute back changes I find useful even on MIT projects. There's no urgency to merge these from my perspective, I'm just sending them as I make them.