Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for simulation duration #76

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add config option for simulation duration #76

merged 1 commit into from
Mar 26, 2024

Conversation

nweires
Copy link
Collaborator

@nweires nweires commented Mar 26, 2024

Make max duration configurable.

Based on a comment on NREL#423, make this configurable because ComStock simulations can be much slower. I followed the example of minutes_per_sim in hpc-spec.

The default behavior is unchanged.

@nweires nweires marked this pull request as ready for review March 26, 2024 17:46
Copy link

File Coverage
All files 87%
base.py 91%
exc.py 57%
hpc.py 78%
local.py 70%
postprocessing.py 84%
utils.py 92%
cloud/docker_base.py 88%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/shared_testing_stuff.py 85%
test/test_docker.py 33%
test/test_local.py 97%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against f4b3d11

@@ -654,8 +654,9 @@ def start_batch_job(self, batch_info):
boot_disk_mib=job_env_cfg.get("boot_disk_mib", None),
)

# Give three minutes per simulation, plus ten minutes for job overhead
task_duration_secs = 60 * (10 + batch_info.n_sims_per_job * 3)
# Use specified time per simulation, plus ten minutes for job overhead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mainly for ComStock, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it in the next section, so yes!

@nweires nweires merged commit e3720d8 into gcp Mar 26, 2024
6 of 7 checks passed
@nweires nweires deleted the natalie/job_time branch March 26, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants