Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes for compatibility with ComStock #73

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Conversation

nweires
Copy link
Collaborator

@nweires nweires commented Mar 19, 2024

  • Cache a list of reporting measures names because some ComStock-specific code (here) tries to fetch them by accessing files that don't exist when running on GCP.
  • Upload other weather files (.ddy and .stat), not just .epws. Also include the empty.* files, which are required (documented here).

Copy link

github-actions bot commented Mar 20, 2024

File Coverage
All files 86%
base.py 91%
exc.py 57%
hpc.py 78%
local.py 70%
postprocessing.py 84%
utils.py 92%
cloud/docker_base.py 78%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/shared_testing_stuff.py 85%
test/test_docker.py 33%
test/test_local.py 97%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 80175da

@nweires nweires merged commit afb7c6d into gcp Mar 21, 2024
6 checks passed
@nweires nweires deleted the natalie/comstock branch March 21, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant