-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for running post-processing on GCP Cloud Run #21
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against a422f63 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level, this looks good to me!
Hopefully we can refactor some of the shared setup code nicely so starting each batch job is concise and easy to read.
This now uses Cloud Run instead of Batch. It's ready for official review except that I need merge in 'gcp' |
# Conflicts: # buildstockbatch/gcp/gcp.py # setup.py
It now uses Cloud Run, so there's no longer as much opportunity/need to share code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Cloud Run job itself looks good - just left some questions about configuration options and usability.
# Conflicts: # buildstockbatch/gcp/gcp.py
Some notes: