Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running post-processing on GCP Cloud Run #21

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Conversation

lathanh
Copy link
Member

@lathanh lathanh commented Nov 9, 2023

Some notes:

  • This is a rough first pass; there's a lot of opportunity for cleanup, but wanted to get some feedback before doing that. That said, all feedback is welcome (e.g., even on obvious cleanup opportunities)
  • It hasn't been rebased onto 'gcp' yet, so the diff currently shows some recent changes on 'gcp' (currently e449578 Fix documentation cross-reference)

@lathanh lathanh added the enhancement New feature or request label Nov 9, 2023
@lathanh lathanh requested a review from nweires November 9, 2023 20:33
@lathanh lathanh self-assigned this Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

File Coverage
All files 85%
base.py 90%
eagle.py 77%
exc.py 57%
local.py 70%
postprocessing.py 84%
utils.py 91%
cloud/docker_base.py 0%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against a422f63

Copy link
Collaborator

@nweires nweires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level, this looks good to me!

Hopefully we can refactor some of the shared setup code nicely so starting each batch job is concise and easy to read.

buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
@lathanh lathanh requested a review from nweires November 10, 2023 19:07
@lathanh
Copy link
Member Author

lathanh commented Nov 10, 2023

This now uses Cloud Run instead of Batch. It's ready for official review except that I need merge in 'gcp'

# Conflicts:
#	buildstockbatch/gcp/gcp.py
#	setup.py
@lathanh lathanh changed the title [DRAFT] Add support for running post-processing on GCP Add support for running post-processing on GCP Cloud Run Nov 10, 2023
@lathanh
Copy link
Member Author

lathanh commented Nov 10, 2023

Hopefully we can refactor some of the shared setup code nicely so starting each batch job is concise and easy to read.

It now uses Cloud Run, so there's no longer as much opportunity/need to share code.

@lathanh lathanh marked this pull request as ready for review November 10, 2023 23:23
Copy link
Collaborator

@nweires nweires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Cloud Run job itself looks good - just left some questions about configuration options and usability.

buildstockbatch/gcp/gcp.py Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
@lathanh lathanh requested a review from nweires November 14, 2023 01:47
@lathanh lathanh merged commit 68faf2f into gcp Nov 15, 2023
6 checks passed
@lathanh lathanh deleted the pp-cloud branch November 15, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants