Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build update skia #926

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Build update skia #926

wants to merge 9 commits into from

Conversation

Et7f3
Copy link
Member

@Et7f3 Et7f3 commented Jun 27, 2020

I have rebased revery-ui/esy-skia on top of mono/skia

Since their is a 10k diff we might copy master in new branch (to not break user that haven't updated because commit are kept)
and I force push the rebased branch in place of master

Question: in drawString method we have a textEncoding and we use always GlyphId (in one test we use Utf8) should we expose textEncoding arguments ?

todo: remove Deprecated module ? (I don't see any mention of a deprecation so it should be fine)

real diff https://github.com/revery-ui/revery/pull/926/files/ffb4669cb639e7cf217292e85bdc0bda0ee472c2..8638b97f3e0a0e620c9c6a5010f4bf15ee4fbbfc (the first one only change resolutions)

@Et7f3 Et7f3 marked this pull request as draft June 27, 2020 07:34
@Et7f3
Copy link
Member Author

Et7f3 commented Jun 27, 2020

Also SkiaSdl return a exit code of 2 and don't do anything.

@github-actions
Copy link

I have updated your lock dirs and formatted the code.
Please @Et7f3 pull the last commit before pushing any more changes.

@github-actions
Copy link

I have updated your lock dirs and formatted the code.
Please @Et7f3 pull the last commit before pushing any more changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant