Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for borderRadius on Images #809

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lessp
Copy link
Member

@lessp lessp commented Apr 6, 2020

This is partly working. The issue seems to be that once you've rendered an image with borderRadius other images won't show. I imagine there's something shared which gets overwritten perhaps.

Will depend on: revery-ui/reason-skia#63

addCircle: https://fiddle.skia.org/c/cd2ad60bbe5f957824e3eb5e074a97d9

addRoundRect: https://fiddle.skia.org/c/757d1efd0a50992e99afc135021e7cd1

@lessp lessp changed the title Feature: Add support for borderRadius on Images feat: add support for borderRadius on Images Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant