This repository has been archived by the owner on Jun 6, 2020. It is now read-only.
Add bindings to GetWindowPosition #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
reviewed
Oct 21, 2019
| CAMLlocal1(ret); | ||
| ret = caml_alloc(2, 0); | ||
|
|
||
| Store_field(ret, 0, x); |
There was a problem hiding this comment.
Does this need to be Store_field(ret, 0, Val_int(x))? I recall sometimes that there would be issues with this - see resdl_SDL_GetWindowSize/resdl_SDL_GetDrawableSize?
bryphe
suggested changes
Oct 21, 2019
There was a problem hiding this comment.
Thanks for making this change, @zbaylin ! Looks great overall - I just had one piece of feedback - it looks like the int values might not make it to the OCaml side in all cases / platforms - I think it needs to be wrapped in a Val_int.
Otherwise, looks great! Thank you for adding this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help with creating a draggable title bar