Resolved unexpected behavior of the display of tweets #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved unexpected behavior of the display of tweets
The show more button was automatically toggled caused by unintended state reset behavior in the useEffect logic that handled window resize events.
This was initially not observed in my testing as it doesnot happen when testing it in a desktop browser with mobile responsive size, but happens in actual mobile/smartphones because the resize on mobile is triggered by various other events , even scrolling could trigger it.
Ive resolved the issue by addressing that.
The check
wasMobile !== isCurrentlyMobileensures that the reset only happens if there is a genuine change in the screen size category.Thank you and sorry for the inconvenience this might have caused.