Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context menu api fix #520

Open
wants to merge 80 commits into
base: main
Choose a base branch
from

Conversation

yofukashino
Copy link
Contributor

@yofukashino yofukashino commented Jul 21, 2023

makes it so you can use React.useState with the api for updating your menu items.

src/renderer/coremods/contextMenu/index.tsx Outdated Show resolved Hide resolved
src/renderer/coremods/contextMenu/index.tsx Show resolved Hide resolved
src/renderer/coremods/contextMenu/index.tsx Outdated Show resolved Hide resolved
@FedeIlLeone FedeIlLeone added bug Something isn't working semver: patch Requires a patch semver version bump labels Jul 22, 2023
@yofukashino
Copy link
Contributor Author

moved back to plain text patch to get less rerenders.

src/renderer/coremods/contextMenu/index.tsx Outdated Show resolved Hide resolved
src/renderer/coremods/contextMenu/index.tsx Outdated Show resolved Hide resolved
src/renderer/coremods/contextMenu/index.tsx Outdated Show resolved Hide resolved
src/renderer/coremods/contextMenu/index.tsx Outdated Show resolved Hide resolved
src/renderer/coremods/contextMenu/index.tsx Outdated Show resolved Hide resolved
src/renderer/coremods/contextMenu/plaintextPatches.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon development Relates to developing addons, eg APIs or scripts bug Something isn't working semver: patch Requires a patch semver version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants