Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filters #22

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix filters #22

wants to merge 7 commits into from

Conversation

Madskill
Copy link
Contributor

This PR fix issue #7

If the key contains square brackets, slash or double quotes, it must be enclosed in double quotes.

@Madskill Madskill mentioned this pull request Feb 10, 2019
@renormalist
Copy link
Owner

I think this here is a workaround for the merge-carnage I created when using uniqnum instead of uniq from another PR.

As far as I understand we could throw away this PR here, now that I have merged the actual quote-fix, right?

@Madskill
Copy link
Contributor Author

Hi!
The PR corrects that issue . The problem is not relate to previous PRs.

If you want to fix it, you should merge this PR. And check that all of tests are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants