Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional "terms of service". Off of optional config point. #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JakubNer
Copy link
Contributor

Optional "Terms of Service" button:

image

As an example, pointing to remotestorage.io's ToS, but can be changed for each deployment.

@raucao raucao requested a review from bencharp March 20, 2022 00:32
Copy link
Contributor

@DougReeder DougReeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add "terms_of_service_url": "" to conf.example.json, so new sysadmins know it's there.

Also, please rebase to the current master branch, and then I think it's good to go!

@@ -41,8 +42,13 @@ <h1>
<button id="switch">Switch</button>
</li>
</ul>
</nav>
</header>
<% if (typeof tosUrl !== 'undefined' && tosUrl) { %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering, what's the && tosUrl for, when it's already not undefined?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! It should probably be
if (typeof tosUrl === 'string' && tosUrl.trim().length > 1)

@bencharp
Copy link
Member

Sorry to answer only now, but wouldn't it be better to place this link in a footer rather than in this menu?

@raucao
Copy link
Member

raucao commented Aug 18, 2022

Makes sense, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants