Type-check lintRule() implementation #290
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
What do you think about narrowing the
coerce()
return type fromunknown
to a type parameter, which is less permissive?What I did was:
[Severity, ...Array<unknown>]
to[Severity, Options|undefined]
unknown
toOptions|[boolean|Label|Severity, (Options|undefined)?]
Options
type parameter in theRule
type