-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings for enforced styles to presets #282
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea!
This should be included in the docs at least.
It’s a breaking change. I’m open to working towards new majors (I’d also want to improve some error messages, which could be considered a major change as well), though that should probably come after by the work on improving markdown formatting which I mentioned in #281 (comment)
Do you have ideas on how to test and document these additions? |
9b4f501
to
875a137
Compare
Thanks for merging #284 (comment)! Ideally I'd like to land #286 and this one (#282 (comment)), then rebase #279 (review)? |
Initial checklist
Description of changes
What I did was, for each preset rule with remark-stringify options in that rule's "fix" documentation, I added that option to the preset's settings.
What this does is, you can apply the preset's remark-stringify options with, e.g.
For example:
[remarkLintUnorderedListMarkerStyle, '-']
settings.bullet
bullet: '-'
-> remark-preset-lint-markdown-style-guide's settings