This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Find translation results with case-insensitive comparison #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what to do about the test failures since they all appear to be problems with the credentials, which I can't control. The tests pass for me locally when I supply my credentials. |
a-bougouin
approved these changes
Jan 12, 2021
|
↑ Sorry, my colleague reviewed thinking this PR was to one of our own repos. |
relrod
approved these changes
Jan 12, 2021
|
Thanks for the patch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft claims e.g. at https://api.cognitive.microsofttranslator.com/languages?api-version=3.0 to support two language codes with regions:
fr-caandpt-ptHowever in the actual response these are normalized to
fr-CAandpt-PT(which is correct per BCP 47 recommendations).With the way this gem currently extracts the translated payload, translations to
fr-caandpt-ptalways result innil. This PR fixes this by performing a case-insensitive comparison.Note that I have used
casecmp.zero?instead ofcasecmp?because the latter is apparently slower (see rubocop/rubocop-performance#100).