Skip to content
This repository has been archived by the owner on Sep 25, 2018. It is now read-only.

Adjust contributor-page (first step in workflow) #11

Open
krokkie opened this issue Jan 7, 2016 · 7 comments
Open

Adjust contributor-page (first step in workflow) #11

krokkie opened this issue Jan 7, 2016 · 7 comments

Comments

@krokkie
Copy link

krokkie commented Jan 7, 2016

  • heading field - remove from common, move to detailed section
  • type field in detailed section = first field, most important.
  • conditional fields: if type=exposition / technical - then show subverse widget
  • conditional fields: if type=application, then show heading + tags, else hide them
@rudolfbyker rudolfbyker self-assigned this Jan 8, 2016
@rudolfbyker
Copy link
Member

@rudolfbyker
Copy link
Member

Conditional fields require the "type"s to be defined by the module, and not in a Taxonomy... See issue #14

rudolfbyker added a commit that referenced this issue Jan 8, 2016
@rudolfbyker
Copy link
Member

The type stays taxonomy_term_reference, but the taxonomy terms now have a field which determines the sort behaviour: "lw_listing_order". Pseduo-code for the last two TODOs:

x = the lw_listing_order field of the taxonomy term referenced by the 'position' (a.k.a. type) field
switch x
  case LIVING_WORD_LISTING_ORDER_SINGLE_SUB_VERSE
    show subverse widget
  case LIVING_WORD_LISTING_ORDER_APPLICATION_TAGS
    show heading field
    show tags field
  case LIVING_WORD_LISTING_ORDER_PREDOMINANT_MULTI_VERSE
    ???
  default
    show nothing extra

@krokkie Please verify if this makes sense...

@krokkie
Copy link
Author

krokkie commented Jan 8, 2016

Lyk reg.

It does not only define the sort order, but also which fields are "required" in the editor, where it is presented in a list, etc.

@rudolfbyker
Copy link
Member

Hmm... in that case, we need new names for the behaviours, and the field should be called lw_listing_behaviour and not lw_listing_order.

rudolfbyker added a commit that referenced this issue Jan 9, 2016
…his helps Issue #11

# Manually resolved conflicts:
#	living_word/living_word.field.inc
@rudolfbyker
Copy link
Member

I propose that we name the possible values of lw_listing_behaviour as follows:

  • LIVING_WORD_LISTING_BEHAVIOUR_BROAD
  • LIVING_WORD_LISTING_BEHAVIOUR_NARROW
  • LIVING_WORD_LISTING_BEHAVIOUR_TOPICAL

@rudolfbyker
Copy link
Member

On the edit page for taxonomy terms in the position vocabulary, one can now select:
screenshot from 2016-02-13 20-16-54

Since commit 1f28b6a, the heading field only appears when application (or any taxonomy term where the field lw_listing_behaviour == LIVING_WORD_LISTING_BEHAVIOUR_TOPICAL) is selected.

Issue #16 blocks this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants