Add a flag to control whether the kubelet runs in "containerized" mode. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e or not. This also adds a build mode for "dynamic" compilation instead of static. This is required for cAdvisor to run in the "non-containerized" kubelet.
| @@ -15,20 +16,28 @@ func (lk *LocalKube) Add(server Server) { | |||
| lk.Servers = append(lk.Servers, server) | |||
| } | |||
|
|
|||
| func (lk *LocalKube) Run(args []string, out io.Writer) error { | |||
| if len(args) < 2 { | |||
| var containerized = flag.Bool("containerized", true, "Whether localkube is inside a container or not") | |||
There was a problem hiding this comment.
Can we auto-detect this by looking at some env vars or inspecting /proc/self/ns?
There was a problem hiding this comment.
Looks like inspecting /proc/1/cgroup should work, but I'd kind of prefer to keep this explicit to match the behavior of the kubelet itself.
Thoughts?
There was a problem hiding this comment.
SGTM. We can revisit this once, kubelet stops exposing the same flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a build mode for "dynamic" compilation instead of static. This is required for cAdvisor to run in the "non-containerized" kubelet.
FYI, this is part of the minikube project: kubernetes/minikube#8