Migrations accept hint #23826
Open
Migrations accept hint #23826
+153
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtanov
force-pushed
the
migrations-accept-hint
branch
from
6620d37
to
f17e24f
Compare
4 tasks
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56743#01929b23-a30c-4187-b091-852386e7dab4 |
Retry command for Build#56743please wait until all jobs are finished before running the slash command |
|
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56743#01929b27-8d27-4422-a6e6-d7c14b2f6086: non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56810#01929fa8-80a4-4100-adb3-ec4ea05f5a51: non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56810#01929fa8-80a5-4f7d-a4b4-36c1302c60ee: non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56810#01929fa8-80a7-44c4-8717-52ff20303943: |
dotnwat
reviewed
Oct 17, 2024
Comment on lines
32
to
41
| // extract location hint from topic name | ||
| ss::sstring tp_hinted = ret.source_topic_name.tp; | ||
| auto slash_pos = tp_hinted.find('/'); | ||
| if (slash_pos != seastar::sstring::npos) { | ||
| ret.cloud_storage_location | ||
| = cluster::data_migrations::cloud_storage_location{ | ||
| .hint = tp_hinted.substr(slash_pos + 1)}; | ||
| ret.source_topic_name.tp = model::topic( | ||
| std::move(tp_hinted).substr(0, slash_pos)); | ||
| } |
There was a problem hiding this comment.
use abseil or boost string splitting? (e.g. absl::StrSplit)
bashtanov
force-pushed
the
migrations-accept-hint
branch
from
f302255
to
b84ca67
Compare
Retry command for Build#56810please wait until all jobs are finished before running the slash command |
asimms41
reviewed
Oct 18, 2024
bashtanov
force-pushed
the
migrations-accept-hint
branch
from
5ab1f07
to
fc7993f
Compare
| @@ -522,6 +522,10 @@ ss::future<errc> backend::do_topic_work( | |||
| state sought_state, | |||
| const inbound_topic_work_info& itwi, | |||
| tsws_lwptr_t tsws) { | |||
| vlog( | |||
| dm_log.trace, | |||
| "itwi.cloud_storage_location = {}", | |||
There was a problem hiding this comment.
can we add more context here f.e. the topic, the itwi is not very informative
There was a problem hiding this comment.
I made it logged in the universal do_topic_work instead, both for in- and outbound migrations
it can be None anyway
bashtanov
force-pushed
the
migrations-accept-hint
branch
from
fc7993f
to
15ce139
Compare
|
/dt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with Matt, accept location hint as part of source topic name when mounting
Backports Required
Release Notes