Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline_log_viewer: allow reading newer versions of envelopes #23803

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Commits on Oct 18, 2024

  1. offline_log_viewer: allow reading newer versions of envelopes

    Before this commit offline log viewer would refuse reading envelopes if
    their version was higher than max_version. That is an overly restrictive
    constraint. Our envelopes are designed to be forward and backwards
    compatible so in most of the cases an older implementation of the log
    viewer should be able to read newer versions of the envelopes just fine.
    
    This commit implements that. Instead of putting a constraint on
    version we constrain only compat_version like regular redpanda
    deserialization would do.
    
    Additional changes include issuing a warning if offline log viewer
    compat version is lower than envelope version. This means that offline
    log viewer will be able to decode only a subset of the envelope.
    
    And obviously added code to skip over data that can't be read by the
    offline log viewer.
    
    Breaking changes in the envelopes are introduced by bumping compat
    version. In that case offline log viewer will refuse the decoding as
    expected.
    nvartolomei committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2e45890 View commit details
    Browse the repository at this point in the history