Update tooling for OCP 4.17; update base images #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Obuchowicz <[email protected]>
Signed-off-by: Andrew Obuchowicz <[email protected]>
Signed-off-by: Andrew Obuchowicz <[email protected]>
dkwon17
requested changes
Oct 11, 2024
README.md
Outdated
| - [oc](https://github.com/openshift/origin) [v4.16.0](https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/4.16.0) | ||
| - [kubectl](https://github.com/kubernetes/kubectl) [v1.29.1](https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/4.16.0) | ||
| - [kustomize](https://github.com/kubernetes-sigs/kustomize) [v5.4.2](https://github.com/kubernetes-sigs/kustomize/tree/kustomize/v5.4.2) | ||
| - [oc](https://github.com/openshift/origin) [v4.17.0](https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/4.17.0) |
There was a problem hiding this comment.
@AObuchow I just noticed that the mirror.openshift.com links need a trailing forward slash or else we get a 404 error. Could you update it?
There was a problem hiding this comment.
Good catch @dkwon17 :) I've updated all the links with required slashes and verified that they now all work.
Signed-off-by: Andrew Obuchowicz <[email protected]>
dkwon17
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tooling used in the web terminal operator tooling container to their latest versions available on mirror.openshift.com and github releases for OCP 4.17, as well as updates the base container images to their latest available versions.
Testing
For convenience, I've pushed the web terminal tooling container built from this PR to
quay.io/aobuchow/wto-tooling:1.12.quay.io/aobuchow/wto-tooling:1.12. Alternatively, create a web terminal with the default image and runwtoctl set image quay.io/aobuchow/wto-tooling:1.12in the web terminal consoleoc versionshould indicate version 4.17.Here's the output of
helpfrom the tooling image, running on the Developer Sandbox: