Remove odo CLI

[AObuchow]

As of WTO 1.11, Web Terminal is based off of UBI9. odo does not currently officially support RHEL9 based images so it is being removed from the tooling image for the time being.

This is part of https://issues.redhat.com/browse/WTO-298.

Some additional notes:

• The changes to rh-manifests.txt were not added in Update tooling for OCP 4.16; update base images  #71, which is why they are present in this change
• There are 3 other mentions of odo in the codebase, though they do not depend on odo being installed. I opted to keep these as they facilitate re-adding odo in the future if odo ends up supporting RHEL 9. However, maybe it's best to remove these?

  • web-terminal-tooling/etc/entrypoint.sh

    Lines 26 to 27 in 6a71b01

    	# Have to close stdin because odo will prompt for telemetry even in an entrypoint
    	/tmp/get-tooling-versions.sh 0<&- > /tmp/installed_tools.txt

  • web-terminal-tooling/etc/initial_config/.zshrc

    Lines 50 to 52 in 6a71b01

    	if command -v odo &>/dev/null; then
    	source <(odo completion zsh)
    	fi

  • web-terminal-tooling/etc/get-tooling-versions.sh

    Lines 54 to 57 in 6a71b01

    	if command -v odo &>/dev/null; then
    	ODO_VER=$(odo version --client | grep -Eo 'v?[0-9]+\.[0-9]+\.[0-9]+')
    	append_ver "odo |${ODO_VER#v} |Red Hat OpenShift Developer CLI"
    	fi

Testing

For convenience, I've pushed the web terminal tooling container built from this PR to quay.io/aobuchow/wto-tooling:1.11-no-odo.

1. Launch an OpenShift 4.16+ cluster. I recommend OpenShift 4.17, since the backport to fix using kubeadmin with WTO has not been merged to OpenShift 4.16 yet.
2. Install the web-terminal operator from Operator Hub
3. Create a web terminal, click the link to specify a custom image, and provide quay.io/aobuchow/wto-tooling:1.11-no-odo. Alternatively, create a web terminal with the default image and run wtoctl set image quay.io/aobuchow/wto-tooling:1.11-no-odo in the web terminal console
4. Verify the web terminal starts up successfully. odo should no longer be found as a command when running odo and the output of help should not include odo

Welcome to the OpenShift Web Terminal. Type "help" for a list of installed CLI tools.
bash-5.1 ~ $ odo
bash: odo: command not found
bash-5.1 ~ $ help
Installed tools:
Command    Version         Name
oc         4.16.0          OpenShift CLI
kubectl    1.29.1          Kubernetes CLI
kustomize  5.4.2           Kustomize CLI
helm       3.14.4          Helm CLI
kn         1.12.0          KNative CLI
tkn        0.37.0          Tekton CLI
subctl     0.17.2          Submariner CLI
virtctl    1.2.2           KubeVirt CLI
rhoas      0.53.0          Red Hat OpenShift Application Services CLI
jq         1.6             jq

To customize this terminal, see 'wtoctl'

[dkwon17]

It works, could you please remove the odo bits as well? It's unnecessary code and we can always add them back later

[AObuchow]

It works, could you please remove the odo bits as well? It's unnecessary code and we can always add them back later

+1 will do

[AObuchow]

@dkwon17 pushed latest changes to remove all traces of odo & pushed changes to quay.io/aobuchow/wto-tooling:1.11-no-odo 👍

[AObuchow]

🤦 I merged the fixup commit.. oh well