Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new application to redirect requests from GitHub #103

Open
wants to merge 3 commits into
base: v2
Choose a base branch
from
Open

Added new application to redirect requests from GitHub #103

wants to merge 3 commits into from

Conversation

Arman084
Copy link

No description provided.

sabre1041
sabre1041 requested changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and deployment was successful. Small change requested

.openshift/templates/smee-webhook.yml
FROM node:latest
RUN npm install --global smee-client
ENTRYPOINT smee -u ${SMEE_URL} -t ${SMEE_TARGET}
type: Binary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be changed to Dockerfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabre1041 sabre1041 sabre1041 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arman084 @sabre1041