-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMTP relay (MailDev) chart #69
Conversation
charts/maildev/values.yaml
Outdated
replicaCount: 1 | ||
|
||
image: | ||
repository: quay.io/jtudelag/maildev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to not go with maildev/maildev
image on Docker Hub? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I could not make it work using env vars....and it is alpine based.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @jtudelag @ckavili .. just to see whats needed as an alternative - i created a ubi based postfix smtp email relay. correct, it must run under anyuid scc (postfix will only run as root) but maybe a lot simpler to setup ?
https://github.com/eformat/openshift-postfix
thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eformat yes, we thought about it as it is the default coming in RHEL, but it must run under anyuid as you said. We wanted to avoid that at all cost.
Also, I would say complexity is more or less the same. For the relay server to be used, you need to configure the server with user & creds, you need a service so the apps can consume it, etc. I don't see any benefits on that side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubi based is straightforward for sure but I'd rather go with rootless as well 😌 and it'd be great if we can add this chart to maildev repo itself and pull it from there in UJ 🙌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ckavili I will open a PR to maildev repo.
Also, I dont get this: ubi based is straightforward for sure but I'd rather go with rootless as well
.
What do you mean exactly? I mean, Using ubi and being rootless are two diferent things...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I meant the one that Mike has built. It's ubi based and just a yum install postfix
. Seems simpler but requires privilege :)
PR made: maildev/maildev#316 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can a conftest be added before merging please:
hey @garethahealy can you point me to some docs on how to write & run those tests you are mentioning? |
you just need to duplicate a block like this: but update it to match whatever helm chart you are using. to run it: |
Thanks for the answer @garethahealy. |
hey, @jtudelag I see your PR has merged in upstream 🎉 Can we close this issue and refer to Maildev in UJ extra tooling maybe? what do you think? |
Yes! although we might want to re-test the chart on top of OCP, as the upstream one has some changes. |
Adds an SMTP relay helm chart based on MailDev.
Addresses rht-labs/ubiquitous-journey#165.
I was thinking on changing the name of the chart, to sth generic like
smtp-relay
just in case we change it in the future.Why did I chose MailDev instead of other options?
Mainly because it does not need to be run as root, on the contrary to postfix for example.