Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP relay (MailDev) chart #69

Closed
wants to merge 1 commit into from
Closed

Conversation

jtudelag
Copy link
Contributor

@jtudelag jtudelag commented Jul 20, 2020

Adds an SMTP relay helm chart based on MailDev.

Addresses rht-labs/ubiquitous-journey#165.

I was thinking on changing the name of the chart, to sth generic like smtp-relay just in case we change it in the future.

Why did I chose MailDev instead of other options?
Mainly because it does not need to be run as root, on the contrary to postfix for example.

@jtudelag jtudelag added the enhancement New feature or request label Jul 20, 2020
replicaCount: 1

image:
repository: quay.io/jtudelag/maildev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to not go with maildev/maildev image on Docker Hub? 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I could not make it work using env vars....and it is alpine based.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @jtudelag @ckavili .. just to see whats needed as an alternative - i created a ubi based postfix smtp email relay. correct, it must run under anyuid scc (postfix will only run as root) but maybe a lot simpler to setup ?

https://github.com/eformat/openshift-postfix

thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eformat yes, we thought about it as it is the default coming in RHEL, but it must run under anyuid as you said. We wanted to avoid that at all cost.

Also, I would say complexity is more or less the same. For the relay server to be used, you need to configure the server with user & creds, you need a service so the apps can consume it, etc. I don't see any benefits on that side.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubi based is straightforward for sure but I'd rather go with rootless as well 😌 and it'd be great if we can add this chart to maildev repo itself and pull it from there in UJ 🙌🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ckavili I will open a PR to maildev repo.

Also, I dont get this: ubi based is straightforward for sure but I'd rather go with rootless as well.
What do you mean exactly? I mean, Using ubi and being rootless are two diferent things...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I meant the one that Mike has built. It's ubi based and just a yum install postfix. Seems simpler but requires privilege :)

@jtudelag
Copy link
Contributor Author

PR made: maildev/maildev#316

Copy link
Contributor

@garethahealy garethahealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can a conftest be added before merging please:

@jtudelag
Copy link
Contributor Author

hey @garethahealy can you point me to some docs on how to write & run those tests you are mentioning?

@garethahealy
Copy link
Contributor

garethahealy commented Aug 24, 2020

you just need to duplicate a block like this:

but update it to match whatever helm chart you are using.
i.e.: tmp=$(helm_template "charts/argocd-operator")

to run it: bats _test/conftest.sh. you'll need a few tools installed:

@jtudelag
Copy link
Contributor Author

Thanks for the answer @garethahealy.
It would be nice then to have some stuff added to the README of this repo regarding testing (links, dependencies, how run a test, etc...).

@ckavili
Copy link
Contributor

ckavili commented Mar 15, 2021

hey, @jtudelag I see your PR has merged in upstream 🎉 Can we close this issue and refer to Maildev in UJ extra tooling maybe? what do you think?

@jtudelag
Copy link
Contributor Author

Yes! although we might want to re-test the chart on top of OCP, as the upstream one has some changes.

@jtudelag jtudelag closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants