Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: adding trustyai coverage for it to be GA in 2.15 #1956

Merged
merged 2 commits into from
Oct 23, 2024
Merged

enhancement: adding trustyai coverage for it to be GA in 2.15 #1956

merged 2 commits into from
Oct 23, 2024

Conversation

CFSNM
Copy link
Contributor

@CFSNM CFSNM commented Oct 23, 2024

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2024
View reviewed changes
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot Fixed Show fixed Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot Fixed Show fixed Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot Fixed Show fixed Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot Fixed Show fixed Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot Fixed Show fixed Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot Fixed Show fixed Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
@@ -274,6 +294,7 @@
${SAVED_MANAGEMENT_STATES.MODELMESHERVING}= Get DSC Component State ${DSC_NAME} modelmeshserving ${OPERATOR_NS}
${SAVED_MANAGEMENT_STATES.MODELREGISTRY}= Get DSC Component State ${DSC_NAME} modelregistry ${OPERATOR_NS}
${SAVED_MANAGEMENT_STATES.KSERVE}= Get DSC Component State ${DSC_NAME} kserve ${OPERATOR_NS}
${SAVED_MANAGEMENT_STATES.TRUSTYAI}= Get DSC Component State ${DSC_NAME} trustyai ${OPERATOR_NS}

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${SAVED_MANAGEMENT_STATES.TRUSTYAI}' is assigned but not used
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
552 0 0 552 100

bdattoma
bdattoma previously approved these changes Oct 23, 2024
View reviewed changes
@CFSNM CFSNM self-assigned this Oct 23, 2024
asanzgom
asanzgom previously approved these changes Oct 23, 2024
View reviewed changes
@CFSNM CFSNM added the verified This PR has been tested with Jenkins label Oct 23, 2024
@CFSNM CFSNM dismissed stale reviews from asanzgom and bdattoma via ff2edd2 October 23, 2024 11:29
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2024
View reviewed changes
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
... check that TrustyAi deployment is created and pod is in Ready state
[Tags] Operator Tier1 RHOAIENG-14018 trustyai-managed

Set DSC Component Managed State And Wait For Completion trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (169/120)
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot

Set DSC Component Managed State And Wait For Completion trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR}

[Teardown] Restore DSC Component State trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR} ${SAVED_MANAGEMENT_STATES.TRUSTYAI}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (196/120)
asanzgom
asanzgom previously approved these changes Oct 23, 2024
View reviewed changes
mattmahoneyrh
mattmahoneyrh previously approved these changes Oct 23, 2024
View reviewed changes
@CFSNM CFSNM removed the verified This PR has been tested with Jenkins label Oct 23, 2024
@CFSNM CFSNM dismissed stale reviews from mattmahoneyrh and asanzgom via 9a6156e October 23, 2024 12:08
@CFSNM CFSNM requested a review from asanzgom October 23, 2024 12:08
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2024
View reviewed changes
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
[Documentation] Validate that TrustyAi management state Removed does remove relevant resources.
[Tags] Operator Tier1 RHOAIENG-14018 trustyai-removed

Set DSC Component Removed State And Wait For Completion trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (169/120)
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot

Set DSC Component Removed State And Wait For Completion trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR}

[Teardown] Restore DSC Component State trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR} ${SAVED_MANAGEMENT_STATES.TRUSTYAI}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (196/120)
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@CFSNM CFSNM added the verified This PR has been tested with Jenkins label Oct 23, 2024
MarianMacik
MarianMacik approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

nehachopra27
nehachopra27 reviewed Oct 23, 2024
View reviewed changes
ods_ci/tasks/Resources/RHODS_OLM/install/oc_install.robot
@@ -136,12 +136,6 @@ Verify RHODS Installation
... label_selector=app.kubernetes.io/name=data-science-pipelines-operator timeout=400s
END

${modelregistry} = Is Component Enabled modelregistry ${DSC_NAME}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing model registry for trustyai?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the model registry section after the trustyai one, because model registry reconciliation happens after the trustyai one, so just to follow the same order to check that the operator does

@CFSNM CFSNM merged commit b632add into red-hat-data-services:master Oct 23, 2024
8 checks passed
@CFSNM CFSNM deleted the trustyai_ga branch October 23, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehachopra27 nehachopra27 nehachopra27 left review comments

@MarianMacik MarianMacik MarianMacik approved these changes

@adolfo-ab adolfo-ab adolfo-ab approved these changes

@bdattoma bdattoma bdattoma approved these changes

@asanzgom asanzgom asanzgom approved these changes

@kobihk kobihk Awaiting requested review from kobihk

@aloganat aloganat Awaiting requested review from aloganat

@jstourac jstourac Awaiting requested review from jstourac

@mattmahoneyrh mattmahoneyrh Awaiting requested review from mattmahoneyrh

Assignees

@CFSNM CFSNM

Labels
verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CFSNM @MarianMacik @mattmahoneyrh @nehachopra27 @adolfo-ab @bdattoma @asanzgom