-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: adding trustyai coverage for it to be GA in 2.15 #1956
Conversation
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
Fixed
Show fixed
Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
Fixed
Show fixed
Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
Fixed
Show fixed
Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
Fixed
Show fixed
Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
Fixed
Show fixed
Hide fixed
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
Fixed
Show fixed
Hide fixed
@@ -274,6 +294,7 @@ | |||
${SAVED_MANAGEMENT_STATES.MODELMESHERVING}= Get DSC Component State ${DSC_NAME} modelmeshserving ${OPERATOR_NS} | |||
${SAVED_MANAGEMENT_STATES.MODELREGISTRY}= Get DSC Component State ${DSC_NAME} modelregistry ${OPERATOR_NS} | |||
${SAVED_MANAGEMENT_STATES.KSERVE}= Get DSC Component State ${DSC_NAME} kserve ${OPERATOR_NS} | |||
${SAVED_MANAGEMENT_STATES.TRUSTYAI}= Get DSC Component State ${DSC_NAME} trustyai ${OPERATOR_NS} |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
Robot Results
|
... check that TrustyAi deployment is created and pod is in Ready state | ||
[Tags] Operator Tier1 RHOAIENG-14018 trustyai-managed | ||
|
||
Set DSC Component Managed State And Wait For Completion trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR} |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
|
||
Set DSC Component Managed State And Wait For Completion trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR} | ||
|
||
[Teardown] Restore DSC Component State trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR} ${SAVED_MANAGEMENT_STATES.TRUSTYAI} |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
[Documentation] Validate that TrustyAi management state Removed does remove relevant resources. | ||
[Tags] Operator Tier1 RHOAIENG-14018 trustyai-removed | ||
|
||
Set DSC Component Removed State And Wait For Completion trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR} |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
|
||
Set DSC Component Removed State And Wait For Completion trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR} | ||
|
||
[Teardown] Restore DSC Component State trustyai ${TRUSTYAI_CONTROLLER_MANAGER_DEPLOYMENT_NAME} ${TRUSTYAI_CONTROLLER_MANAGER_LABEL_SELECTOR} ${SAVED_MANAGEMENT_STATES.TRUSTYAI} |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@@ -136,12 +136,6 @@ Verify RHODS Installation | |||
... label_selector=app.kubernetes.io/name=data-science-pipelines-operator timeout=400s | |||
END | |||
|
|||
${modelregistry} = Is Component Enabled modelregistry ${DSC_NAME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing model registry for trustyai?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the model registry section after the trustyai one, because model registry reconciliation happens after the trustyai one, so just to follow the same order to check that the operator does
Related ticket: https://issues.redhat.com/browse/RHOAIENG-14018