-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mktemp on macOS #1520
base: master
Are you sure you want to change the base?
fix mktemp on macOS #1520
Conversation
Signed-off-by: lugi0 <[email protected]>
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: lugi0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this won't break it for some other MacOS users with older systems since I don't understand how it worked for them fine 🙃
Anyway, LGTM now, thank!
I tried it on Mac It does not throw any error, but does not either create a directory called
|
Quality Gate failedFailed conditions |
@asanzgom Where are you launching the script from? The root of the repo or from its |
The creation of a temp dir in the test-output folder for ods-ci appears to be broken in macOS, causing the
run_robot_test.sh
script to fail when run on a vanilla system using all defaults.This variation of the command will create a directory called
ods-ci-$(date +%Y-%m-%d-%H-%M)-XXXXXXXXXX)
within the TEST_ARTIFACT_DIR directory (i.e. by defaultods_ci/test-output/
).