Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mktemp on macOS #1520

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lugi0
Copy link
Contributor

@lugi0 lugi0 commented Jun 12, 2024

The creation of a temp dir in the test-output folder for ods-ci appears to be broken in macOS, causing the run_robot_test.sh script to fail when run on a vanilla system using all defaults.
This variation of the command will create a directory called ods-ci-$(date +%Y-%m-%d-%H-%M)-XXXXXXXXXX) within the TEST_ARTIFACT_DIR directory (i.e. by default ods_ci/test-output/).

Signed-off-by: lugi0 <[email protected]>
@lugi0 lugi0 self-assigned this Jun 12, 2024
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
475 0 0 475 100

ods_ci/run_robot_test.sh Outdated Show resolved Hide resolved
FedeAlonso
FedeAlonso previously approved these changes Jun 12, 2024
Copy link
Contributor

@FedeAlonso FedeAlonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this won't break it for some other MacOS users with older systems since I don't understand how it worked for them fine 🙃

Anyway, LGTM now, thank!

@asanzgom
Copy link
Contributor

I tried it on Mac It does not throw any error, but does not either create a directory called ods-ci-$(date +%Y-%m-%d-%H-%M)-XXXXXXXXXX) within the TEST_ARTIFACT_DIR directory (i.e. by default ods_ci/test-output/)
After triggering Test Case with changes on run_robot_tests.sh:

$ ls -lu /Users/asanzgom/Work/ods-ci/ods_ci/ods_ci/test-output/
total 1272
-rw-r--r-- 1 asanzgom staff 272741 12 jun 12:21 log.html
-rw-r--r-- 1 asanzgom staff 127930 12 jun 12:21 output.xml
-rw-r--r-- 1 asanzgom staff 232884 12 jun 12:21 test_report.html
-rw-r--r-- 1 asanzgom staff   443 12 jun 12:21 xunit_test_result.xml

@asanzgom asanzgom self-requested a review June 12, 2024 10:30
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@lugi0
Copy link
Contributor Author

lugi0 commented Jun 12, 2024

@asanzgom Where are you launching the script from? The root of the repo or from its ods_ci subfolder?
From your logs I can see an ods_ci too many in the path
/Users/asanzgom/Work/ods-ci/ods_ci/ods_ci/test-output/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants