global: fix graceful shutdown #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 71.73% 71.42% -0.31%
==========================================
Files 15 15
Lines 1394 1400 +6
==========================================
Hits 1000 1000
- Misses 394 400 +6
|
When using the shell form of `CMD`, the provided command is executed using `/bin/sh -c`, which breaks signal propagation. Use `exec` to substitute the `sh` process and fix handling of signals by uwsgi. Also handle SIGTERM in `consume-job-queue` to gracefully stop consuming the job status queue. Closes reanahub/reana-job-controller#347
mdonadoni
force-pushed
the
graceful-shutdown
branch
from
acd1ff9
to
a2c5baa
Compare
giuseppe-steduto
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the shell form of
CMD, the provided command is executedusing
/bin/sh -c, which breaks signal propagation. Useexectosubstitute the
shprocess and fix handling of signals by uwsgi.Also handle SIGTERM in
consume-job-queueto gracefully stop consumingthe job status queue.
Closes reanahub/reana-job-controller#347