-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest core #7837
Update to latest core #7837
Conversation
@@ -51,10 +50,6 @@ public static OsAppCredentials apiKey(String key) { | |||
return new OsAppCredentials(nativeCreate(TYPE_API_KEY, key)); | |||
} | |||
|
|||
public static OsAppCredentials serverApiKey(String key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't really used and not exposed in the SDK. Removed from core in realm/realm-core#5914
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update sync error codes and deprecate old ones.
# Conflicts: # CHANGELOG.md
Ready for review |
realm/realm-library/src/androidTest/java/io/realm/LinkingObjectsQueryTests.java
Outdated
Show resolved
Hide resolved
@@ -401,11 +400,11 @@ public void isEmpty_acrossLink() { | |||
case LINKING_OBJECTS: | |||
// Rows 0 and 1 are not included as they are linked to another row through FIELD_OBJECT | |||
// Row 2 is included (no link) | |||
assertEquals(1, realm.where(AllJavaTypesUnsupportedTypes.class).isEmpty(AllJavaTypesUnsupportedTypes.FIELD_OBJECT + "." + AllJavaTypesUnsupportedTypes.FIELD_LO_OBJECT).count()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the expected values changed for these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was changed after realm/realm-core#6867. There was a lot of discussion about this, but in the end, we determined that the old behavior was buggy and subsequently fixed.
java_error_message = JavaLocalRef<jstring>(env, env->NewStringUTF( | ||
status.reason().c_str())); | ||
java_error_code = JavaLocalRef<jobject>(env, JavaClassGlobalDef::new_long(env, static_cast<int32_t>(status.code()))); | ||
java_error_message = JavaLocalRef<jstring>(env, env->NewStringUTF( status.reason().c_str())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use to_jstring
?
Closes #7775