Use 16 KB ELF alignment for shared native libraries (#7897)

https://developer.android.com/guide/practices/page-sizes
realm · Sep 13, 2024 · a69ad2f · a69ad2f
1 parent e564a45
commit a69ad2f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,7 +7,7 @@
 * None.
 
 ### Fixed
-* None.
+* Use 16 KB ELF packaging for native artifacts produced by `realm-library`, allowing them to be loaded on devices with 16 KB memory page sizes. (Issue [#7894](https://github.com/realm/realm-java/issues/7894))
 
 ### Compatibility
 * File format: Generates Realms with format v23. Unsynced Realms will be upgraded from Realm Java 2.0 and later. Synced Realms can only be read and upgraded if created with Realm Java v10.0.0-BETA.1.

diff --git a/realm/realm-library/build.gradle b/realm/realm-library/build.gradle
@@ -121,6 +121,11 @@ android {
  // We did strip with cmake for release build.
  // Please, Gradle, you are not that smart! Pleas DO NOT strip debug symbols for debug build!
  doNotStrip "*/*/*.so"
+
+ // Use compressed shared libraries to support 16 KB ELF alignment
+ jniLibs {
+ useLegacyPackaging = true
+ }
  }
 
  lintOptions {

diff --git a/realm/realm-library/src/main/cpp/CMakeLists.txt b/realm/realm-library/src/main/cpp/CMakeLists.txt
@@ -214,6 +214,9 @@ endif()
 add_library(realm-jni SHARED ${jni_SRC})
 target_link_libraries(realm-jni log android Realm::ObjectStore)
 
+# Use 16 KB ELF alignment to support devices with page size greater than 4 KB
+target_link_options(realm-jni PRIVATE "-Wl,-z,max-page-size=16384")
+
 # Strip the release so files and backup the unstripped versions
 if (buildTypeCap STREQUAL "Release")
  set(unstripped_SO_DIR