Add new subscribe API #3403
Add new subscribe API #3403
Conversation
Pull Request Test Coverage Report for Build 5736508132
💛 - Coveralls |
| @@ -1,11 +1,23 @@ | |||
| ## vNext (TBD) | |||
|
|
|||
| ### Enhancements | |||
| * None | |||
| * Added `IQueryable.SubscribeAsync` API as a shorthand for using `SubscriptionSet.Add`. It is a syntax sugar that roughly translates to: | |||
There was a problem hiding this comment.
I would add the equivalent code that uses SubscribeAsync, so it's a little bit clearer
| { | ||
| var tcs = new TaskCompletionSource(); | ||
| if (cancellationToken?.IsCancellationRequested == true) | ||
| { | ||
| tcs.TrySetCanceled(cancellationToken.Value); |
There was a problem hiding this comment.
I am not sure I understand why we need this and the following line. Can we just return?
There was a problem hiding this comment.
If cancellation is requested, the expected behavior would be to throw a TaskCancelledException, even if we didn't start doing the work. Regarding why we're cancelling the tcs vs throwing a TaskCancelledException, I guess both are roughly the same and don't have strong feelings about one or the other.
That's why you're supposed to read the PR description 😜 |
Description
Fixes RNET-865
Adds
IQueryable.SubscribeAsyncsyntax sugar.Adds
cancellationTokenargument toSession.WaitForDownloadAsync,Session.WaitForUploadAsync, andSubscriptionSet.WaitForSynchronization. This doesn't cancel the underlying Core wait operation, just the managed task. While it's not ideal, the native wait operation is not really expensive and it will eventually complete anyway, so we are not leaking resources.There are some whitespace changes, so it might be a good idea to review with the "Ignore whitespace" option.
TODO