RCORE-2227 Updated non-streaming upload progress to report 1.0 if nothing to upload

[michael-wb]

What, How & Why?

Currently, the non-streaming upload progress callback notifications would report an estimate of 0.0 and the notification callback was being expired if the uploadable and uploaded values were reported as zero. Since the notification estimate is being expired, it make better sense to report the estimate of 1.0, since that suggests that the notification request is complete.

These changes update the notification callback invocation routine to report an estimate of 1.0 if the uploaded and uploadable values are 0. The original tests that checked for 0.0 were updated.

In addition, some of the tests were SyncProgressNotifier::update() with an estimates of 0.0 when the uploadable/uploaded or downloadable/downloaded values were zero. These calls were updated to provide an estimate of 1.0, since that mimics the actual behavior of the sync client progress reporting.

Fixes #7952

☑️ ToDos

• 📝 Changelog update
• 🚦 Tests (or not relevant)
• [ ] C-API, if public C++ API changed
• [ ] bindgen/spec.yml, if public C++ API changed

[coveralls-official]

Pull Request Test Coverage Report for Build michael.wilkersonbarker_1316

Details

• 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
• 61 unchanged lines in 12 files lost coverage.
• Overall coverage decreased (-0.007%) to 91.095%

---

Files with Coverage Reduction	New Missed Lines	%
src/realm/dictionary.cpp	1	85.16%
src/realm/sort_descriptor.cpp	1	94.06%
test/test_util_network_ssl.cpp	1	89.59%
src/realm/cluster.cpp	2	75.85%
src/realm/sync/network/http.hpp	2	82.27%
src/realm/sync/client.cpp	3	90.96%
src/realm/sync/noinst/protocol_codec.hpp	3	75.74%
test/fuzz_group.cpp	4	46.41%
src/realm/sync/noinst/server/server.cpp	5	74.61%
src/realm/index_string.cpp	8	84.63%

Totals
Change from base Build 2546:	-0.007%
Covered Lines:	217009
Relevant Lines:	238222

---

💛 - Coveralls

[michael-wb]

No longer being done since an upload progress report should not be sent if there is nothing to upload after a client reset.