Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve android crash issue if props are undefined #571

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

gamingumar
Copy link
Contributor

In some cases, children are not available yet or props are undefined in Android which causes the app to crash

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naturalclar Naturalclar merged commit 243ead2 into react-native-picker:master Jun 10, 2024
6 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 10, 2024
## [2.7.7](v2.7.6...v2.7.7) (2024-06-10)

### Bug Fixes

* resolve android crash issue if props are undefined ([#571](#571)) ([243ead2](243ead2))
@Naturalclar
Copy link
Contributor

🎉 This PR is included in version 2.7.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@williamgurzoni
Copy link

Hey @gamingumar this is causing an issue for react-native-picker-select as mentioned here. Is this really necessary? Should we solve it in a way to keep the behavior for both iOS and Android?

Quick introduction of why this is causing problems: The mentioned package adds a null item when the user specifies a placeholder for the dropdown. Before, the user was able to select the placeholder to "reset" the value. Now it works only for iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants