fix: The fixed attribute does not take effect #1193

yezhonghu0503 · 2024-09-21T09:19:56Z

修复表格expandable中设置fixed：right不生效，issues：ant-design/ant-design#50846

问题原因

对于fixed的处理不正确，一个是判断逻辑有问题，fixed不应该和expandIconColumnIndex一起判断，一个是插入扩展列的时候没有按照fixed的值来处理

如何修复

插入时增加判断，当设置fixed为left或者，fixed没设置时，默认插入到列数据数组第一个，如果fixed为right则插入到最后一个
修改fixedColumn变量表达传入位置到逻辑

Summary by CodeRabbit

新功能
- 增强了列管理的灵活性，允许更动态地处理展开列的位置和列的固定状态。

vercel · 2024-09-21T09:20:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
table	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 30, 2024 9:36am

coderabbitai · 2024-09-21T09:20:11Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

tests/__snapshots__/ExpandRow.spec.jsx.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

此次更改涉及useColumns函数的逻辑修改，主要集中在插入展开列和确定列的固定位置的逻辑。更新后的条件允许在更多场景下插入展开列，并简化了确定固定列的逻辑，以提高列管理的灵活性。

Changes

文件路径	更改摘要
src/hooks/useColumns/index.tsx	修改了插入展开列的逻辑和固定列的确定方式，增强了列管理的灵活性。

Possibly related PRs

fix: dynamic sticky #1184: useSticky钩子的更改可能与整体列管理和布局行为相关，因为这两个PR都涉及组件如何处理其定位和渲染逻辑的调整。

Poem

在列中跳跃的小兔子，
展开新列乐无比。
固定位置随心变，
灵活管理乐无边。
代码更新如春风，
兔子欢跳乐融融！ 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

afc163 · 2024-09-21T12:25:40Z

搞个测试用例 cover 一下

yezhonghu0503 · 2024-09-21T15:34:22Z

搞个测试用例 cover 一下

ok，稍等

yezhonghu0503 · 2024-09-21T16:01:42Z

看了下测试用例，没考虑到expandIconColumnIndex小于0时是不渲染的，修改了一下判断条件

codecov · 2024-09-22T09:55:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (c74c46d) to head (3030cbb).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
+ Coverage   97.70%   97.73%   +0.02%     
==========================================
  Files          75       75              
  Lines        7420     7422       +2     
  Branches     1112     1114       +2     
==========================================
+ Hits         7250     7254       +4     
+ Misses        164      162       -2     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yezhonghu0503 · 2024-09-30T07:08:52Z

搞个测试用例 cover 一下

佬，这个pr为啥还不给合并捏

yoyo837 · 2024-09-30T07:10:01Z

src/hooks/useColumns/index.tsx

@@ -176,9 +176,13 @@ function useColumns<RecordType>(
 // >>> Insert expand column if not exist
 if (!cloneColumns.includes(EXPAND_COLUMN)) {
 const expandColIndex = expandIconColumnIndex || 0;
- if (expandColIndex >= 0) {
+ console.log(expandColIndex);


删除调试语句

afc163 · 2024-09-30T07:26:03Z

最好还是单独给个用例，单看 snap 的改变不容易看出是不是符合预期。

yezhonghu0503 · 2024-09-30T08:46:33Z

最好还是单独给个用例，单看 snap 的改变不容易看出是不是符合预期。

哦哦，明白鸟

fix: The fixed attribute does not take effect

f49dd25

vercel bot deployed to Preview September 21, 2024 09:20 View deployment

fix: Rectify the case that expandIconColumnIndex is smaller than 0

c3c5bfe

vercel bot deployed to Preview September 21, 2024 16:01 View deployment

fix: update Table.Expand snapshoot

3030cbb

vercel bot deployed to Preview September 22, 2024 09:47 View deployment

yoyo837 reviewed Sep 30, 2024

View reviewed changes

Merge branch 'react-component:master' into master

f31d159

vercel bot deployed to Preview September 30, 2024 09:36 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: The fixed attribute does not take effect #1193

fix: The fixed attribute does not take effect #1193

yezhonghu0503 commented Sep 21, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Sep 21, 2024 •

edited

Loading

coderabbitai bot commented Sep 21, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

afc163 commented Sep 21, 2024

yezhonghu0503 commented Sep 21, 2024

yezhonghu0503 commented Sep 21, 2024

codecov bot commented Sep 22, 2024

yezhonghu0503 commented Sep 30, 2024

yoyo837 Sep 30, 2024

yezhonghu0503 Sep 30, 2024

afc163 commented Sep 30, 2024

yezhonghu0503 commented Sep 30, 2024

fix: The fixed attribute does not take effect #1193

Are you sure you want to change the base?

fix: The fixed attribute does not take effect #1193

Conversation

yezhonghu0503 commented Sep 21, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Sep 21, 2024 • edited Loading

coderabbitai bot commented Sep 21, 2024 • edited Loading

Review skipped

Walkthrough

Changes

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

afc163 commented Sep 21, 2024

yezhonghu0503 commented Sep 21, 2024

yezhonghu0503 commented Sep 21, 2024

codecov bot commented Sep 22, 2024

Codecov Report

yezhonghu0503 commented Sep 30, 2024

yoyo837 Sep 30, 2024

Choose a reason for hiding this comment

yezhonghu0503 Sep 30, 2024

Choose a reason for hiding this comment

afc163 commented Sep 30, 2024

yezhonghu0503 commented Sep 30, 2024

yezhonghu0503 commented Sep 21, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Sep 21, 2024 •

edited

Loading

coderabbitai bot commented Sep 21, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)