Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support max length #313

Closed
wants to merge 7 commits into from
Closed

feat: support max length #313

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
373b294
feat: support max length
hengkx Apr 7, 2021
3afcbfb
Update input.test.tsx
hengkx Apr 8, 2021
7f479e1
Update src/InputNumber.tsx
hengkx Apr 8, 2021
971b777
Update InputNumber.tsx
hengkx Apr 8, 2021
7e5c598
Update input.test.tsx
hengkx Apr 8, 2021
aa6cea0
Update input.test.tsx
hengkx Apr 8, 2021
76d2bf8
Update input.test.tsx
hengkx Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,13 +232,20 @@ online example: https://input-number.vercel.app/
<td></td>
<td>Specifies the inputmode of input</td>
</tr>
<tr>
<td>maxLength</td>
<td>number</td>
<td></td>
<td>input max length</td>
</tr>
</tbody>
</table>

## Keyboard Navigation
* When you hit the <kbd>⬆</kbd> or <kbd>⬇</kbd> key, the input value will be increased or decreased by `step`
* With the <kbd>Shift</kbd> key (<kbd>Shift+⬆</kbd>, <kbd>Shift+⬇</kbd>), the input value will be changed by `10 * step`
* With the <kbd>Ctrl</kbd> or <kbd>⌘</kbd> key (<kbd>Ctrl+⬆</kbd> or <kbd>⌘+⬆</kbd> or <kbd>Ctrl+⬇</kbd> or <kbd>⌘+⬇</kbd> ), the input value will be changed by `0.1 * step`

- When you hit the <kbd>⬆</kbd> or <kbd>⬇</kbd> key, the input value will be increased or decreased by `step`
- With the <kbd>Shift</kbd> key (<kbd>Shift+⬆</kbd>, <kbd>Shift+⬇</kbd>), the input value will be changed by `10 * step`
- With the <kbd>Ctrl</kbd> or <kbd>⌘</kbd> key (<kbd>Ctrl+⬆</kbd> or <kbd>⌘+⬆</kbd> or <kbd>Ctrl+⬇</kbd> or <kbd>⌘+⬇</kbd> ), the input value will be changed by `0.1 * step`

## Test Case

Expand Down
9 changes: 7 additions & 2 deletions src/InputNumber.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ export interface InputNumberProps<T extends ValueType = ValueType>
// useTouch: boolean;

// size?: ISize;
maxLength?: number;
}

const InputNumber = React.forwardRef(
Expand All @@ -92,6 +93,7 @@ const InputNumber = React.forwardRef(
formatter,
precision,
decimalSeparator,
maxLength,

onChange,
onInput,
Expand Down Expand Up @@ -336,8 +338,11 @@ const InputNumber = React.forwardRef(
};

// >>> Input
const onInternalInput: React.ChangeEventHandler<HTMLInputElement> = (e) => {
const onInternalInput: React.ChangeEventHandler<HTMLInputElement> = e => {
let inputStr = e.target.value;
if (maxLength) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

来个测试用例哈~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (maxLength) {
if (maxLength >= 0) {

这样会不会好些？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太对哦，是不是 大于0 就行了 等于 没有任何意义吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太对哦，是不是 大于0 就行了 等于 没有任何意义吧

主要目的是为了判断为数字

inputStr = inputStr.slice(0, maxLength);
}

// optimize for chinese input experience
// https://github.com/ant-design/ant-design/issues/8196
Expand Down Expand Up @@ -404,7 +409,7 @@ const InputNumber = React.forwardRef(
}
};

const onKeyDown: React.KeyboardEventHandler<HTMLInputElement> = (event) => {
const onKeyDown: React.KeyboardEventHandler<HTMLInputElement> = event => {
const { which } = event;
userTypingRef.current = true;

Expand Down