Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MeshCat core (three.js to v0.160.1) #252

Merged
merged 4 commits into from
Apr 21, 2024
Merged

Conversation

ferrolho
Copy link
Collaborator

@ferrolho ferrolho commented Mar 17, 2024

Comparison of differences in MeshCat core: meshcat-dev/meshcat@978cb8f...601b55d

Fixes #251.

Comparison of differences in meshcat: meshcat-dev/meshcat@978cb8f...e87530b
@ferrolho ferrolho added the enhancement New feature or request label Mar 17, 2024
@ferrolho ferrolho self-assigned this Mar 17, 2024
@ferrolho
Copy link
Collaborator Author

ferrolho commented Apr 18, 2024

Hi @nhz2, can you check if this PR solves the issue you reported in #251?

You can give it a go with ]add MeshCat #hf/update-meshcat-core. Thanks in advance!

Artifacts.toml Outdated Show resolved Hide resolved
@nhz2
Copy link

nhz2 commented Apr 18, 2024

Yes, this solves the issue in #251. Thank you.

It would also be good to have a more stable URL to fix #248 as well, ref: meshcat-dev/meshcat#164 (comment)

@ferrolho ferrolho changed the title Update MeshCat core Update MeshCat core (three.js to v0.160.1) Apr 19, 2024
@ferrolho
Copy link
Collaborator Author

ferrolho commented Apr 20, 2024

Waiting on meshcat-dev/meshcat#180 before merging.

Actually, I think we can just merge this now... Merging! 🚀

@ferrolho ferrolho merged commit 1da3802 into master Apr 21, 2024
5 checks passed
@ferrolho ferrolho deleted the hf/update-meshcat-core branch April 21, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants