NI C# Style Guide

Welcome to NI's internal and external C# conventions and linter rules/plugins/tooling.

ni/csharp-styleguide serves several purposes:

It contains our coding conventions/style guides for all C# code written for NI.
It contains custom Roslyn analyzers to enforce rules in our conventions that could not be found elsewhere.
It contains a package that can be consumed by a C# project to automatically configure coding conventions and analyzers.

Quickstart

Package Reference

Add a package reference to the package NI.CSharp.Analyzers. To find the latest versions, look here.

<PackageReference Include="NI.CSharp.Analyzers" Version="<package-version>" />

Note: Currently, this package only works for projects that reference it using PackageReference. Using packages.config to reference the package is not going to work.

Rulesets

Inside of the content directory of this NuGet package are the NI rulesets. NI.ruleset will be applied by default. If your project starts with Tests. or !Tests, or ends with .Tests, the NI.Tests.ruleset will be used. If your project starts with TestUtilities. or !TestUtilities., the NI.TestUtilities.ruleset will be used.

Coding Conventions

NI C# Style Guide
- Quickstart
  - Package Reference
  - Rulesets
- Coding Conventions
Purpose of coding conventions
How to Read This Document
Formatting
Naming
Code Organization
Language Features
Documentation and Comments
Maintainability

Purpose of coding conventions

Coding conventions serve the following purposes:

They create a consistent look to the code, so that readers can focus on content, not layout.
They enable readers to understand the code more quickly by making assumptions based on previous experience.
They facilitate copying, changing, and maintaining the code.
They demonstrate C# best practices.

This is a living document that represents our coding conventions. Rules that are outlined in this document are set and are not expected to change. New rules may be added over time.

How to Read This Document

The conventions in this document are written using the style from Framework Design Guidelines: Conventions, Idioms, and Patterns for Reusable .NET Libraries, 2nd Edition, by Krzysztof Cwalina and Brad Abrams:

✔️ DO - a rule that should always be followed.

✔️ CONSIDER - a rule that should generally be followed, but can be disregarded if you fully understand the reasoning behind the rule and have a good reason not to follow it.

❌ AVOID - a rule indicating something is generally not a good idea, but there are known cases where breaking the rule makes sense.

❌ DO NOT - a rule that indicates something you should almost never do.

💻 - The coding convention is automatically enforced either through an .editorconfig setting or a Roslyn analyzer

Formatting

[F.1] Character Spacing

[F.1.1] ✔️ DO Use a single space after commas separating parameters 💻

// Bad
Console.In.Read(myChar,0,1);

// Good
Console.In.Read(myChar, 0, 1);

[F.1.2] ❌ DO NOT Use spaces between parentheses and parameters 💻

// Bad
CreateFoo( myChar, 0, 1 )

// Good
CreateFoo(myChar, 0, 1);

[F.1.3] ❌ DO NOT Use spaces between index operator brackets and the index expression 💻

// Bad
x = dataArray[ index ];

// Good
x = dataArray[index];

[F.1.4] ❌ DO NOT Use spaces between method names and parentheses 💻

// Bad
CreateFoo ()

// Good
CreateFoo()

[F.1.5] ✔️ DO Use a single space after control flow keywords 💻

// Bad
while(x == y)

// Good
while (x == y)

[F.1.6] ✔️ DO Use a single space before and after comparison operators 💻

// Bad
if (x==y)

// Good
if (x == y)

[F.2] Line Spacing

[F.2.1] ✔️ DO Separate type members with a single blank line, except private fields

// Bad
public class Foo
{
    private float _height;

    private float _width;
    public Foo() { }
    public Initialize() { }
}

// Good
public class Foo
{
    private float _height;
    private float _width;

    public Foo() { }

    public Initialize() { }
}

[F.2.2] ✔️ CONSIDER Use single blank lines to split method bodies into logically-related lines

Consider whether logical grouping of functionality can be better expressed by extracting a method.

// Bad - no spaces to form logical breaks in code
string firstName = GetFirstNameOfPerson(x);
string lastName = GetLastNameOfPerson(x);
int employeeId = GetEmployeeId(x);
var employee = new Employee(firstName, lastName, employeeId);
int costCenter = 2026;
EmployeeDirectory directory = GetDirectoryForCostCenter(costCenter);
directory.AddEmployeeToDirectory(employee);
directory.UpdateDirectory();
UpdateDirectoryMailingList(directory);

// Better - use blank lines to separate code into logically-related sections
string firstName = GetFirstNameOfPerson(x);
string lastName = GetLastNameOfPerson(x);
int employeeId = GetEmployeeId(x);
var employee = new Employee(firstName, lastName, employeeId);

int costCenter = 2026;
EmployeeDirectory directory = GetDirectoryForCostCenter(costCenter);
directory.AddEmployeeToDirectory(employee);
directory.UpdateDirectory();

UpdateDirectoryMailingList(directory);

// Best - extract logic into well-named methods
Employee employee = CreateEmployeeEntry(x);
EmployeeDirectory directory = UpdateDirectoryWithEmployee(employee);
UpdateDirectoryMailingList(directory);

[F.2.3] ❌ DO NOT Place a blank line immediately inside curly braces 💻

// Bad
if (x == 1)
{

    return true;
}

// Good
if (x == 1)
{
    return true;
}

[F.2.4] ❌ DO NOT Place multiple blank lines together 💻

[F.2.5] ✔️ DO Separate unrelated control flow blocks with a blank line

// Bad
if (value == 0)
{
}
else if (value == 1)
{
}
if (defaultValue == 0)
{
}

// Good
// Separate independent `if` clauses with a blank line.
// This avoids confusion between independent conditional logic and an `else if` condition.
if (value == 0)
{
}
else if (value == 1)
{
}

if (defaultValue == 0)
{
}

// Bad
for (int i = 0; i < 4; i++)
{
    // ...
}
for (int j = 0; j < 4; j++)
{
   // ...
}

// Good
for (int i = 0; i < 4; i++)
{
    // ...
}

for (int j = 0; j < 4; j++)
{
   // ...
}

[F.3] Statement Complexity

[F.3.1] ❌ AVOID Adding excessive complexity in compound statements

Each C# statement should be easy to read and understand. If a line has greater than 150 characters, PREFER splitting the statement into multiple lines. Long statements often indicate complexity and can cause three problems:

Conceptual complexity
- Multiple operations in a single statement makes it difficult to understand the intent
- Invoking multiple dotted properties/methods in a single statement can make operations harder to understand and mask possible failure points

// Bad
// If labelOfMatchedNode is null, it's not clear which part of the nested LINQ query failed.
// diagram.Nodes<OfType>() could return empty or the there were no nodes without bounds.Top > 100.
DiagramLabel labelOfMatchedNode = diagram.Nodes.OfType<Add>().Select(x => x.Bounds).Where(x => x.Top > 100).FirstOrDefault();

// Good
var addNodesOnDiagram = diagram.Nodes.OfType<Add>();
DiagramLabel offsetAddNodeLabel = addNodesOnDiagram.Select(x => x.Bounds).Where(x => x.Top > 100).FirstOrDefault();

Visual complexity
- Lines with numerous operators and/or parentheses are hard to visually parse
- Nested method calls are a particular problem because it is hard to tell which parameters are passed to which methods
- Parentheses for numeric or boolean expressions cause similar problems
Horizontal visibility
- Scrolling horizontally increases the likelihood to miss incorrect code, especially in a code review

[F.3.2] ✔️ CONSIDER Extracting methods from complex nested expressions

If you need to evaluate a complex expression, such as a nested numeric or boolean expression, extract that expression to a well-named method.

// Bad
return FooMethod(5, isFooEnabled && (modeFlags & Mode.A || modeFlags & Mode.B));

// Good
bool fullyEnabled = IsFooFullyEnabled();
return FooMethod(5, fullyEnabled);

private bool IsFooFullyEnabled(Mode modeFlags)
{
    return _isFooEnabled && (modeFlags & Mode.A || modeFlags & Mode.B);
}

[F.3.3] ✔️ CONSIDER Splitting long parameter lists

If a given method takes so many parameters that the line becomes very long, split the parameter list so that each parameter is on its own line.

Favor readability over a specific line length, but aim to keep lines under 150 characters. See [F.3.1] ❌ AVOID Adding excessive complexity in compound statements.

Indent the parameter list one level deeper than the invocation that takes the parameters.

// Bad
ConfigureMyObject(objectName, CalculateBitLength(), Enumerable.Empty<int>(), CalculateUniqueOutputPath(initialPath), downstreamDependencies: originalObjectDependencies.Where(x => x.Direction == Direction.Downstream);

// Good
ConfigureMyObject(
    objectName, 
    CalculateBitLength(), 
    Enumerable.Empty<int>(), 
    CalculateUniqueOutputPath(initialPath), 
    downstreamDependencies: originalObjectDependencies.Where(x => x.Direction == Direction.Downstream));

[F.3.4] ✔️ DO Split chains of method invocations with lambda expressions 💻

If you invoke a chain of methods with lambda expressions, split each invocation (except the first one) onto its own line. Use well-named local variables if needed.

There is no hard limit on line length. Use judgement to keep code easy to read and diff. See [F.3.1] ❌ AVOID Adding excessive complexity in compound statements.

Indent dotted invocations one level deeper than the root object. Place the dot for each invocation at the beginning of that line.

// Bad
var availableTables = enabledMeasurements.SelectMany(measurement => measurement.Results).Select(result => result.Tables).Where(table => table.Available);

// Good
var availableTables = enabledMeasurements.SelectMany(measurement => measurement.Results)
    .Select(result => result.Tables)
    .Where(table => table.Available);

If you end up indenting deeper than 2 more levels, CONSIDER extracting local variables.

[F.3.5] ✔️ DO Apply consistent formatting on split statements

If a single statement must include a long chain or nested tree of sub-statements, split the line as follows:

Place operators at the beginning of lines rather than the end of the previous line.
Use indentation to clarify nesting relationships. When splitting a parenthesized sub-expression, indent it one more level than the previous line.
Split related operations at the same level. For example, if you add 5 related items, split each add operation onto a line at the same indentation level.

// Bad
if ((stringBuilderNode.Terminals.ElementAt(0) != null && stringBuilderNode.Terminals.ElementAt(0).Connected) || 
    (stringBuilderNode.Terminals.ElementAt(1) != null && stringBuilderNode.Terminals.ElementAt(1).Connected))

// Good
if ((stringBuilderNode.Terminals.ElementAt(0) != null && stringBuilderNode.Terminals.ElementAt(0).Connected) 
    || (stringBuilderNode.Terminals.ElementAt(1) != null && stringBuilderNode.Terminals.ElementAt(1).Connected))

// Bad (some terms are on the same line, some are on a separate line -- be consistent)
return pathLength + (bendsCount * router.Options.BendCost)
    + (crossingCount * router.Options.CrossingCost) + penalty + weight;

// Good
return pathLength
    + (bendsCount * router.Options.BendCost)
    + (crossingCount * router.Options.CrossingCost)
    + penalty
    + weight;

NOTE: This rule is partially enforced. The analyzer enforces conditional operators but not other operators such as +

[F.4] Indents and Braces

[F.4.1] ✔️ DO Use 4 space characters for indentation, never tab characters

ℹ️ Note: Elsewhere in this document, "indent one level" always means 4 spaces deeper than the previous lines.

[F.4.2] ❌ DO NOT Use single-line statements with control flow keywords 💻

// Bad
if (completed) return;

[F.4.3] ✔️ DO Use braces around statement blocks governed by a control flow keyword (`if`, `else`, `while`), even if statement block is one line 💻

// Bad
if (completed)
    return;

// Good
if (completed)
{
    return;
}

[F.4.4] ✔️ DO Place open curly braces on the next line after the opening statement of an embedded scope block 💻

This applies to scope blocks for control flow keywords, using statements, try-catch-finally, etc.

[F.4.5] ❌ Avoid Placing multiple statements in a `switch` `case` block

If a case block requires multiple statements, extract a helper method.

[F.4.6] ❌ DO NOT Use single-line scopes EXCEPT for single-item initializers or auto-implemented properties

Single-line initializers or auto-implemented properties may use single-line scopes if appropriate, but it is not required.

// Bad
var animals = new List<Animal>() { new Cat("Ragdoll"), new Dog("Corgi") };

// Good
var animals = new List<Animal()
{
    new Cat("Ragdoll"),
    new Dog("Corgi")
}

// Good
var mailingList = new List<string>() { "DefaultEmail" };

// Good
public class Foo
{
    public int Bar { get; set; }
}

[F.4.7] ✔️ DO Format multiple array or object property initializer statements into a multi-line embedded scope block

Place each property or array element value on its own line, indented one level deeper than the curly braces.

var specialObjects = new List<SpecialObject>() 
{
    new SpecialObject() 
    {
       PropertyA = 1,
       PropertyB = "str"
    },
    new SpecialObject() 
    {
       PropertyA = 2,
       PropertyB = "str2"
    }
};

If the initializer is simple enough and easily fits on one line, it can be placed all on one line:

var cat = new Animal() { Noise = "Meow" };

[F.4.8] ✔️ CONSIDER Using C# lambda syntax for simple property and method implementations

The guidance for general lamdba formatting applies to this syntax as well. If the lambda does not fit on the same line as the definition, use the braced syntax.

public class Foo
{
    private int _bar;

    public Foo(int bar) => _bar = bar;

    public int Bar => _bar;
}

[F.4.9] ✔️ DO Use braces with lambda expressions that span multiple lines

When writing a lambda, only use a non-braced version if it fits cleanly on one line. Consider extracting a method any time a lambda cannot fit on one line or takes multiple parameters. If splitting a single lambda statement onto multiple lines, always use indented braces.

// Bad - too complex, use braced indentation instead
await this.WaitForIdleAsync("No item with warning", () => viewModel.GetItem(envoy) != null && viewModel.GetItem(envoy).Overlay == OverlayStatus.Warning);

// Bad - used braced lambda, but incorrect indentation
await this.WaitForIdleAsync("No item with warning", () => 
{
    viewModel.GetItem(envoy) != null && viewModel.GetItem(envoy).Overlay == OverlayStatus.Warning);
}

// Good
await this.WaitForIdleAsync(
    "No item with warning", 
    () => 
    {
        var item = viewModel.GetItem(envoy);
        return item != null && item.Overlay == OverlayStatus.Warning;
    });

Note: Our test authoring pattern violates the indentation rules. Breaking the indentation rule is the format decided upon in the golden tests, and it is the exception to the rule.

public void Given_When_Then()
{
    this.RunTestAsync(async () =>
    {
        // Given
        // When
        // Then
    });
}

Naming

[N.1] Casing Style

[N.1.1] ✔️ DO Apply consistent casing style for identifiers 💻

Style	Identifier Type	Example
Pascal Casing	Types (Classes/Structs/...)	`FeatureInfo`
	Visible tuples	`(float W, float H)`
	Interfaces	`ISelectionCommand`
	Methods	`DeletePage`
	Local Functions	`HandleSelection`
	Properties	`IsValid`
	Events	`CollectionChanged`
	`const` fields and variables	`DefaultPatternKey`
	Namespaces	`PlatformFramework`
Camel Casing	Parameters	`fileName`
	Locals	`selectedItems`
Underscore + Camel Casing	Fields/Member variables	`_activeDesigner`

❗ Special exception: When using product names in identifiers, match the trademarked product name. For example in an API that is exclusive to the shipping LabVIEW product, use "LabVIEW", not "LabView" or "labVIEW".

[N.1.2] ✔️ DO Use underscore + camelCase for private fields and member variables

private bool _inEdit;

NOTE: There is an IDE rule, IDE1006 that flags this but it's only in the editor. IDE rules cannot be enforced at build time.

[N.1.3] ✔️ DO Capitalize both letters of two-letter acronyms

Two-letter acronyms are always either all uppercase or all lowercase. For more information on what two-letter acronyms are considered accepted, refer to <<N.2>> (for general explanation)

Identifier	Bad	Good
NI	Ni	ni, NI
VI	Vi	vi, VI
UI	Ui	ui, UI
IO	Io	io, IO

[N.1.4] ✔️ DO Apply PascalCase style when using 3+letter acronyms

Treat acronyms with more than two letters as words. For more information on what two-letter acronyms are considered accepted, refer to <<N.X>> (for general explanation)

Identifier	Bad	Good
FPGA	FPGA	fpga, Fpga
HTTP	HTTP	http, Http
cRIO	cRIO	crio, Crio, CompactRio

[N.1.5] ❌ DO NOT Use ALL CAPS for any name

One possible exception is when using P/Invokes in a NativeMethods class, if the native method requires that specific capitalization.

[N.2] Acronyms and Abbreviations

[N.2.1] ❌ DO NOT Use acronyms unless they are generally accepted within NI or our client domains

Examples of exceptions:

NI for National Instruments
Fpga for Field Programmable Gate Array
Common framework or protocol names such as Smtp or Etw

[N.2.2] ❌ DO NOT Use abbreviations unless they are commonly accepted terms

Some abbreviations and acronyms are domain-specific and are not necessarily common knowledge to all developers. Use only non-domain abbreviations to avoid confusion. Spell out all words minus a few, rare exceptions.

Bad	Good
num	number
ms	milliseconds
src	source

Examples of allowed abbreviations

Word	Valid Abbreviation
Identifier	Id
Information	Info

[N.3] ❌ DO NOT Use product names in APIs unless those APIs are truly exclusive to that product

Example: Using the name LabVIEW in code in the NationalInstruments.VI namespace is not appropriate because the code for VIs is included in products not called LabVIEW.

[N.4] ✔️ CONSIDER Using parameter/property names that imply usage, not structure. In general, do not embed type information into names

Bad	Good
`public static RoutedEvent SelectionChangedEvent;`	`public static RoutedEvent SelectionChanged`
`public Guid AddAlert(ImageSource imageSource) { }`	`public Guid AddAlert(ImageSource icon) { }`
`public ICollection<int> ScoreCollection { get; }`	`public ICollection<int> Scores { get; }`
`internal static readonly ICommandEx FilterByDeviceCommand;`	`internal static readonly ICommandEx FilterByDevice;`

[N.5] Identifier Prefixing

[N.5.1] ✔️ DO Prefix interfaces with `I` 💻

[N.5.2] ❌ DO NOT Prefix enums, classes or delegates with any letter

Interfaces must begin with I but that is the only exception to this rule.

[N.5.3] ✔️ DO Prefix private fields and member variables with an underscore `_` 💻

NOTE: There is an IDE rule, IDE1006 that flags this but it's only in the editor. IDE rules cannot be enforced at build time.

[N.6] Properties and Methods

[N.6.1] ✔️ DO Name properties with nouns instead of verbs

Properties should never contain the word Get. A getter already is implied when using a property, so the name is redundant. Keep the name short and succinct to what the property represents.

[N.6.2] ✔️ DO Name methods with verbs instead of nouns

[N.6.3] ✔️ DO Use the proper words to imply performance/allocation characteristics

Prefix	Implication
Get	Method execution is fast. Safe to call within a loop
Find	Method execution may be slow. Not safe to call within a loop
Create	Method represents a factory that will allocate an object when called

Code Organization

[C.1] Namespaces

For information on when to create or not create a namespace, read CSharp Coding Conventions Appendix: Namespaces.

[C.1.1] ✔️ DO Prefix namespace names with a company name to prevent namespaces from different companies from having the same name

[C.1.2] ✔️ DO Organize the hierarchy of namespaces around groups of related technologies

[C.1.3] ✔️ DO Use PascalCasing and separate namespace components with periods

For example: Microsoft.Office.PowerPoint

If your brand employs nontraditional casing, you should follow the casing defined by your brand, even if it deviates from normal namespace casing.

[C.1.4] ✔️ CONSIDER Using plural namespace names where appropriate

For example, use System.Collections instead of System.Collection

Brand names and acronyms are exceptions to this rule, however. For example, use System.IO instead of System.IOs.

[C.1.5] ❌ DO NOT Use the same name for a namespace and a type in that namespace

For example, do not use Debug as a namespace name and then also provide a class named Debug in the same namespace. Several compilers require such types to be fully qualified.

[C.1.6] ✔️ DO Create namespaces of the form `NationalInstruments.<ComponentName>.<SubComponentName>.xxx`

ℹ️ Note: In some situations, use the product name as a replacement for ComponentName in the namesapce.

[C.1.7] ✔️ DO Place modeling types in a `NationalInstruments.<ComponentName>.SourceModel` namespace

[C.1.8] ✔️ DO Place View Models / Views of a Model Type in a `NationalInstruments.<ComponentName>.Design` namespace

[C.1.9] ✔️ DO Place Dfir types in a `NationalInstruments.<ComponentName>.Dfir` namespace

[C.1.10] ✔️ DO Place types which are common to both SourceModel and Dfir in a `NationalInstruments.<ComponentName>.CommonModel` namespace

[C.1.11] ✔️ DO Ensure files in an assembly are under the assembly's root namespace and the namespace matches the folder hierarchy on disk

Everything in an assembly should be in that assembly's root namespace or a sub-namespace of that namespace. Source directory layout under the project should match the namespacing under that root namespace.

The MocCommon assembly has a root namespace NationalInstruments.MocCommon, so all types in that assembly should begin with NationalInstruments.MocCommon. For example: NationalInstruments.MocCommon.Design.ClusterViewModel should be in a folder Design in the MocCommon project.

[C.1.12] ✔️ CONSIDER Naming the assembly to match the root namespace

Example: The root namespace of the Fpga project is NationalInstruments.Fpga. Similarly, the root namespace of the Fpga.HelpTools project is NationalInstruments.Fpga.HelpTools.

This pattern isn't present in some projects like PlatformFramework for legacy reasons, where the root namespace is just NationalInstruments. The above rule about folder structure still applies in those projects.

This rule does not apply for test projects. See Regression Test Conventions for namespacing rules in test projects.

If the root namespace results in an assembly name conflict, consider changing the namespace and/or assembly boundaries. If the conflict cannot be avoided, add an additional segment to the assembly name to avoid the conflict. Typically this would be one of the namespaces used in the assembly.

An assembly that contains types in NationalInstruments.SourceModel and NationalInstruments.Designer would have a root namespace of NationalInstruments but its assembly might be named NationalInstruments.SourceModel.dll.

[C.2] ✔️ DO Place public types not intended for use outside the defining assembly's component in a `Restricted` namespace

We can change Restricted types more easily because we know all references are within that component and can be updated together.

Restricted types should be in a namespace of the form:

NationalInstruments.Restricted.<ComponentName>.<SubComponentName>.xxx

Internal types should not go in the Restricted namespace.

[C.3] ✔️ CONSIDER Having one public or internal type per file and its name should match the file's name

Exceptions may be made to the one "main" type per file rule for public/internal types that are only used as part of the interface to the main type and no other types.

Examples include:

A delegate type passed as a callback within the main type API.
An enum specific to the main type.
A class that inherits from EventArgs and is used solely as a parameter to events of the main type in the same file.
A class or struct used as a collection of parameters in the main type API. This could be an options input parameter or bundled return values for an async method to avoid unnamed tuples.

ℹ️ Even in these cases, consider whether exposing the type outside the main type is required. If not, make it a nested type.

[C.4] Usings

[C.4.1] ✔️ DO Place `using` directives at top of file, outside `namespace` 💻

[C.4.2] ✔️ DO Sort `using` directives 💻

Sort using directives in the following order. Always sort alphabetically by namespace, except for aliases (see below).

using system namespaces
using non-system namespaces (e.g. NationalInstruments.*)
using static types in system namespaces
using static types in non-system namespaces
using alias directives; sorted alphabetically by alias name, not namespace

[C.5] ❌ DO NOT Expose nested types as `public` or `internal`

public and internal types should not be nested inside of classes. Create a separate file with the nested type as an outer type instead. Nesting private or protected types is allowed. Nested public types are allowed only in test assemblies as XUnit requires the types to be public for theory data.

NOTE: An analyzer partially enforces this. Public nested types are not allowed, but the rule does not flag nested internal types which our conventions also explicitly disallow.

[C.6] ✔️ CONSIDER Arranging types and members in logical layers

There is no hard rule on the ordering of types within a file (fields, properties, events, constructors, methods, ...). Instead favor a logical organization where readability is the most important thing. Organize type members into logical layers that allows someone browsing the file from the top to see an overview of the functionality then decide if they need to look further into the details.

Suggested layers:

Fields, including static fields and constants
Constructors
Public members (methods, properties, etc)
Private members, with callees after callers

[C.7] Local Functions

[C.7.1] ✔️ DO Place local functions at the end of the containing method

[C.7.2] ❌ DO NOT Nest local functions

Create multiple local functions within the containing method instead of nesting them within each other.

[C.8] ❌ AVOID Using regions

#region/#endregion may seem helpful to organize related code, but they are difficult to maintain over time. As more people modify the file and the file is merged with conflict changes, the more the regions drift and start to contain things that they weren't intended to contain. A region with incorrect contents is worse than having no regions at all as the organization of regions can no longer be trusted.

Language Features

[L.1] ✔️ DO Use primitive C# types instead of Framework Class Library (FCL) types

C# provides primitive types (keywords) for most of the .NET FCL types. Use primitive types instead of FCL types. The one exception to this rule is when specifying the bit width of an integer fields (as the FCL types do) would make the code more clear.

// Bad
SByte, Byte, Int16, UInt16, Int32, UInt32, Int64, UInt64, Char,
Single, Double, Boolean, Decimal, Object, String

// Good
sbyte, byte, short, ushort, int, uint, long, ulong, char,
float, double, bool, decimal, object, string

[L.2] Casting

[L.2.1] ✔️ DO Null-check the result of an `as` cast

[L.2.2] ✔️ CONSIDER Using `is` type matching to `as` plus null check

// Consider
if (foo is Bar b)
{
    b.BarMethod();
}

Equivalent as cast pattern

// Avoid
Bar b = foo as Bar;
if (b != null)
{
    b.BarMethod();
}

[L.2.3] ✔️ CONSIDER Using C-style casting if failed cast should throw an exception

This is faster than as casting + null check, and standardizes the exception message.

[L.3] ❌ AVOID Using `var` when it hinders the understanding of the code, or if the type cannot be inferred on the line it's declared on

// Consider
var itemsToProcess = new List<string>();
...
foreach (var item in itemsToProcess)
{
   // ...
}

[L.4] Constructors

[L.4.1] ✔️ CONSIDER Having one public constructor per class

If your class is overridable and you want deriving classes to have access to it, make the most general constructor protected. If your class is not overridable and/or you want to hide it from the users of your class, make the most general constructor private (not internal).

[L.4.2] ❌ AVOID Doing work in more than one constructor overload (ideally constructors don't do any work)

Provide the most general constructor that encapsulates all of the functionality of the other public constructors. Have the less-general public constructors call the most general. If you want users to have access to all the parameters at once, make the most general constructor public.

[L.4.3] ✔️ CONSIDER Having only required parameters for constructors

Constructors should only contain parameters that are required and use initializers (properties) to set additional optional values.

[L.5] Exceptions

[L.5.1] ✔️ DO Write exception-safe code

Treat every line of code as having the potential to throw an exception. Code should be written such that exceptions cleanly abort the current operation, leaving all data structures in a consistent state that is balanced with respect to paired operations (e.g. init/cleanup).

For more information about writing exception-safe code, please refer to CSharp Coding Conventions Appendix: Writing exception-safe code

[L.5.2] ✔️ DO Throw exceptions instead of returning error codes or null

No function should return an error code or a null value. If the function cannot satisfy its contract, throw an exception. If there is a case where failure is common, you may provide a "Try" style function that is a mirror of the main function prefixed with the word "Try" and does not throw. For instance:

/// <summary>
/// Returns a new MyStuff instance.
/// </summary>
/// <exception cref="MyStuffException>Thrown if we cannot obtain MyStuff.</exception>
public MyStuff DoSomeStuff()
{
  ...
}
 
/// <summary>
/// Returns a new MyStuff instance, or null if unsuccessful.
/// </summary>
public bool TryDoSomeStuff(out MyStuff stuff)
{
   ...
}

[L.6] Events

[L.6.1] ✔️ CONSIDER Following standard conventions for event handlers (naming, inheritance and implementation)

When defining an event that a C# class can raise, follow the steps outlined in CSharp Coding Conventions Appendix: Events regarding naming and implementation.

[L.6.2] ❌ AVOID Using multi-threaded events

Multi-threaded events are difficult to write properly to handle all situations. If it is necessary, please read and follow the guidelines outlined in CSharp Coding Conventions Appendix: Multi-threaded events

[L.7] ✔️ CONSIDER Handling out of range values for enumerations

Do not assume that enumeration arguments will be in the defined range. Do argument checking and throw an exception if the argument is out of range. However, if an enumeration can be out of range by design (for extensibility), handle those out of range cases nicely.

public Styles Style
{
    get
    {
        return _style;
    }
    set
    {
        if (!Enum.IsDefined(typeof(value), value) 
        {
            throw new InvalidEnumArgumentException();
        }
        _style = value;
    }
}

Using the Verifier static class can do this for you.

[L.8] ✔️ CONSIDER Checking input parameters to a function that can be null or out of range

Following the philosophy of Fail-fast, check all parameters using methods from the Verifier static class at the beginning of all methods in a public API. This helps to ensure that parameters outside of the expected range do not get passed in.

[L.9] ❌ AVOID Using tuples in public APIs in product code

Use well-named enums, structs and classes to pass data between methods instead of tuples.

[L.10] ❌ DO NOT Prefix numeric literals with `_`

C# 7.0 added numeric literal syntax improvements where you can use underscores as digit separators. User underscores to enhance readability of large numbers, but do not prefix the number with an underscore.

[L.11] ❌ DO NOT Use `this.` to access member of a class

Reserve usage of this. for calling mixin methods available from test utilities. this. shouldn't be used anywhere in production code.

[L.12] Properties and Methods

[L.12.1] ❌ DO NOT Introduce side effects when calling properties

Properties should be safe to call multiple times and not affect the state of the system. It is okay to do a one-time, tiny hit and then cache the value for subsequent returns.

[L.12.2] ❌ DO NOT Allocate each time a property is called

It is okay for properties to allocate objects once and then cache the value. Subsequent calls to the property should return a cached value rather than returning a new instance each time. If you need to return a few object for each call, use a method prefixed with Create instead.

// Bad - do not allocate multiple times in a property
public Foo CurrentFoo => new Foo();

// Good - allocate in a factory method instead
public Foo CreateFoo()
{
    return new Foo();
}

// Good - cache the result and allocate only once
private Foo _currentFoo;

public Foo CurrentFoo
{
    get
    {
        if (_currentFoo == null)
        {
            _currentFoo = new Foo();
        }

        return _currentFoo;
    }
}

[L.13] ❌ DO NOT Use LINQ query syntax

Do not use query/SQL syntax for LINQ expressions; use method/object syntax instead. Having only one way to read/write LINQ expressions increases consistency in our code.

// Bad - do not use query syntax for LINQ expressions
public void Foo()
{
    var someEnumerableItems = new[] { 1, 2, 3 };
    var queryResult = from item in someEnumerableItems
                      where item > 1
                      select item;
}

// Good - use method syntax for LINQ expressions
public void Foo()
{
    var someEnumerableItems = new[] { 1, 2, 3 };
    var queryResult = someEnumerableItems.Where(item => item > 1);
}

Documentation and Comments

[D.1] ✔️ DO Document public and protected members of APIs

All types, and all members with public/protected scope (in production code) require documentation. Take the time to write good documentation, as external clients and first-time users of the code base often read documentation before using the API. Private/internal types, properties, and methods do not require documentation, but you should add documentation where it can ease future understanding and maintenance of the code.

Format documentation as XML doc comments. Refer to the table below:

Tag	Explanation
`<summary></summary>`	Explain what the class/method does and how/why/when to use it. Keep the summary to a couple sentences. Use for more information
`<param name="parameterName"></param>`	Document each parameter and its purpose in the method.
`<paramref="parameterName"/>`	Refer to parameters of your method in documentation.
`<typeparam name="TypeParameterName"></typeparam>`	Document each type parameter of a generic class or method.
`<typeparamref="TypeParameterName"/>`	Refer to type parameters in documentation for a generic method or class.
`<returns></returns>`	Explain what the method returns: the return value and any expected state changes after the method is done executing.
`<remarks></remarks>`	Add other commentary to your method, in addition to what the method does or when to call it.
`<exception cref="ExceptionName"></exception>`	Document known exceptions the method can throw. Typically used for exceptions that can be caught and ignored/logged, when they will not put your application into a bad state.
`<see cref="ClassName.MethodName"/>`	Provide navigation to classes, methods and other items defined in C#.
`<inheritdoc/>` or `<inheritdoc cref="ClassName.MethodName"/>`	Inherit documentation from a base interface/class.

❗ Special exception: In test assemblies (excluding test utilities), the only documentation required is the <summary> for the test class itself. All other documentation in test files are optional.

Public API Documentation Example

/// <summary>
/// Queries a module at <paramref name="moduleIPAddress"/> with the given <paramref name="query"/>. If the query was successful,
/// the module will transition to an enabled state and support subsequent queries.
/// </summary>
/// <param name="moduleIPAddress">The address of the module to query.</param>
/// <param name="query">The query to check and enable on the module.</param>
/// <returns>The status of the module. If the query fails, this will return <see cref="ModuleStatus.QueryUnavailable"/>.</returns>
/// <remarks>This method expects a valid IP address. If there is no module at the specified IP address, this method will throw.</remarks>
/// <exception cref="ModuleNotFoundException">
/// Throws this exception if there is no module at the specified IP address.
/// </exception>
public static ModuleStatus QueryAndEnableModule(string moduleIPAddress, QueryCommand query)

Private API Documentation Example

/// <inheritdoc cref="QueryAndEnableModule"/>
/// <param name="forceQuery">Force the module to support the query as an absolute override</param>
/// <remarks>This extends the QueryAndEnableModule functionality in situations when the module doesn't support the specified <paramref name="query"/>.</remarks>
private static ModuleStatus QueryAndEnableModule(string moduleIPAddress, QueryCommand query, bool forceQuery)

NOTE: There are three different XML doc comments that do not conform to a fully documented public API method. However, for a private method this is okay. Removing any of these does not cause compile errors. The main issue is that people are duplicating documentation or making verbose, redundant documentation on private methods that are unnecessary.

[D.2] ❌ DO NOT Duplicate documentation from methods with the same name but different signatures

If you are overriding a member (method or property) or implementing an interface member, use <inheritdoc/> rather than copy/pasting the base comment. When using <inheritdoc/>, you must still document any parameters that differ from the original method.

[D.3] ❌ DO NOT Nest `<remarks>` and `<exceptions>` inside `<summary>` tags

[D.4] ✔️ DO Place a link to an actual task/user story in `TODO` comments

TODO comments should not exist outside the scope of a feature and should therefore be associated with a concrete task or user story. Before a feature is accepted, all TODOs with a feature must be removed from the code.

[D.5] ❌ DO NOT Put names, initials or anything pertaining to individual developers into a `TODO` comment

Developers change teams, organizations or companies. Not only do names become stale, it can be very difficult translate initials to developers. As we move to more vertical teams, names in comments become less meaningful and even confusing. Work items are persistent and can be associated with teams which makes things easier to track and follow up on.

[D.6] ✔️ DO Use "AB#nnnnnn" format to reference AzDO (Azure Boards) work items in comments

Code tends to last longer than work item tracking systems. Each reference should declare what system it came from. The AB# prefix is the standard adopted by GitHub for this purpose.

Maintainability

[M.1] External dependencies

[M.1.1] ❌ AVOID Rewriting Framework Class Library (FCL) API implementations

Do not write your own "better" version of classes in the FCL. Use the classes from the FCL. Adding new versions adds to developer confusion. (i.e. Which version should be used in what scenario?)

Don't use 3rd party libraries as replacement for classes in the FCL unless there is an extremely important reason for doing so. For example, Wintellect has created a set of Power Collections for .NET that extends the FCL with an algorithms class and a series of new containers. Don't use that library just because it exists. Once again, this only adds to developer confusion.

If you find a need to extend a class from the FCL, prefer the use of a 3rd party libraries over writing your own. For example, consider using Wintellect's Power Collections for .NET rather than creating your own versions of that functionality.

[M.2] ✔️ DO Place English localizable strings into a resource file

[M.3] ✔️ DO Ensure projects have "Check for arithmetic overflow/underflow" enabled for Debug/Release Builds and disabled for Distribution builds

There are performance implications for enabling that setting for distribution builds but it will catch important issues that we want to address.

Name		Name	Last commit message	Last commit date
Latest commit History 145 Commits
.github		.github
build		build
docs		docs
src		src
tests		tests
.editorconfig		.editorconfig
.gitattributes		.gitattributes
.gitignore		.gitignore
Directory.Build.props		Directory.Build.props
Directory.Build.targets		Directory.Build.targets
GitVersion.yml		GitVersion.yml
LICENSE.txt		LICENSE.txt
NationalInstruments.Analyzers.sln		NationalInstruments.Analyzers.sln
README.md		README.md
_config.yml		_config.yml
nuget.config		nuget.config

License

rbell517/csharp-styleguide

Folders and files

Latest commit

History

Repository files navigation