Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable checkbox cursor for disabled table rows [DSSUP-157] #2383

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kabilansakthivelu
Copy link

@kabilansakthivelu kabilansakthivelu commented Oct 18, 2024

Description

Updated cursor style for Checkbox component and handled TableHeader checkbox for disabled state when all the table rows are disabled

Changes

Fixes: DSSUP-157

Checkbox - active state:

Checkbox - Active state

Checkbox - disabled state:

Checkbox - Disabled state

Table - Active row:

Table - Active row

Table - Disabled row:

Table - Disabled row

When all the table rows are disabled, made the Table Header checkbox also to disabled state. However, the background color of the Table Header affects the appearance of the checkbox when it's in disabled state.

Screenshot 2024-10-18 at 00 02 31

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 3ab045b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 18, 2024

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Oct 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ab045b:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented Oct 21, 2024

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
ActionList, ActionListItem, ActionListItemAvatar, ActionListItemBadge, ActionListItemBadgeGroup, ActionListItemIcon, ActionListItemText, ActionListSection 16.072 16.094 +0.022 KB
Checkbox 5.969 5.991 +0.022 KB
Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions, TableEditableCell, TableEditableDropdownCell 64.832 64.878 +0.046 KB
Tabs, TabItem, TabList, TabPanel 7.004 7.003 -0.001 KB
PhoneNumberInput 59.577 59.594 +0.017 KB

Generated by 🚫 dangerJS against 3ab045b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants